Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #704: Footer doesn't reflect theme changes solved #760

Closed
wants to merge 1 commit into from

Conversation

Mujahid087
Copy link

Type of PR:

  • Bug fix
  • [ ]Feature enhancement
  • [ ]Documentation update
  • [ ]Other (specify): ___________

Description:

This pull request aims to fix the bug where the footer section did not update its theme based on user selections for light or dark mode. The theme toggle is now functional throughout the entire page, including the footer. Additionally, user preferences are saved in local Storage to maintain the selected theme across sessions._

Before:

The footer did not switch to dark mode when the theme toggle was activated, leading to inconsistent styling between the main page and the footer.

After:

The footer now responds to theme changes, switching smoothly between light and dark modes in alignment with the rest of the page.

Checklist

  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Context

In addition to fixing the theme toggle issue, I tested the toggle functionality across page reloads to ensure that the stored theme preference is applied reliably to all page sections, including the footer. This update offers a consistent visual experience for users by syncing the footer's appearance with the chosen theme.

Thank you for reviewing my pull request!

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 5:17am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Mujahid087! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit c05b1e7
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/672d9ecbf5a9980008958241
😎 Deploy Preview https://deploy-preview-760--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 9, 2024

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

17 similar comments
Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@Mujahid087 Mujahid087 closed this by deleting the head repository Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant