-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #704: Footer doesn't reflect theme changes solved #760
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @Mujahid087! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
✅ Deploy Preview for collect-your-gamingtools ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi there! This issue is still open. We are looking forward to your response. |
17 similar comments
Hi there! This issue is still open. We are looking forward to your response. |
Hi there! This issue is still open. We are looking forward to your response. |
Hi there! This issue is still open. We are looking forward to your response. |
Hi there! This issue is still open. We are looking forward to your response. |
Hi there! This issue is still open. We are looking forward to your response. |
Hi there! This issue is still open. We are looking forward to your response. |
Hi there! This issue is still open. We are looking forward to your response. |
Hi there! This issue is still open. We are looking forward to your response. |
Hi there! This issue is still open. We are looking forward to your response. |
Hi there! This issue is still open. We are looking forward to your response. |
Hi there! This issue is still open. We are looking forward to your response. |
Hi there! This issue is still open. We are looking forward to your response. |
Hi there! This issue is still open. We are looking forward to your response. |
Hi there! This issue is still open. We are looking forward to your response. |
Hi there! This issue is still open. We are looking forward to your response. |
Hi there! This issue is still open. We are looking forward to your response. |
Hi there! This issue is still open. We are looking forward to your response. |
Type of PR:
Description:
This pull request aims to fix the bug where the footer section did not update its theme based on user selections for light or dark mode. The theme toggle is now functional throughout the entire page, including the footer. Additionally, user preferences are saved in local Storage to maintain the selected theme across sessions._
Before:
The footer did not switch to dark mode when the theme toggle was activated, leading to inconsistent styling between the main page and the footer.
After:
The footer now responds to theme changes, switching smoothly between light and dark modes in alignment with the rest of the page.
Checklist
Additional Context
In addition to fixing the theme toggle issue, I tested the toggle functionality across page reloads to ensure that the stored theme preference is applied reliably to all page sections, including the footer. This update offers a consistent visual experience for users by syncing the footer's appearance with the chosen theme.
Thank you for reviewing my pull request!