forked from Azure/azure-sdk-tools
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python APIView] add support for pyproject.toml managed packages #1
Draft
swathipil
wants to merge
69
commits into
swathipil/pyapi/add-py-tspconfig
Choose a base branch
from
swathipil/pyapi-mergeafter-tt/pyproject-toml-only2
base: swathipil/pyapi/add-py-tspconfig
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Python APIView] add support for pyproject.toml managed packages #1
swathipil
wants to merge
69
commits into
swathipil/pyapi/add-py-tspconfig
from
swathipil/pyapi-mergeafter-tt/pyproject-toml-only2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ified in pyproject.toml
…mergeafter-tt/pyproject-toml-only2
swathipil
commented
Feb 4, 2025
@@ -201,6 +200,12 @@ def _find_modules(self, pkg_root_path): | |||
# Add current path as module name if _init.py is present | |||
if INIT_PY_FILE in files: | |||
module_name = os.path.relpath(root, pkg_root_path).replace(os.path.sep, ".") | |||
# If namespace has not been set yet, try to find the first __init__.py that's not purely for extension or tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking for first non-extension init.py, as per @scbedd's advice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Merge after Azure#9146 has been merged.
fixes: Azure#9617
Closed Azure#9692 in favor of this PR. Rebased on top of tree token parser updates (Azure#9146).