Redesign jextract-swift: plugins and avoid custom swift features #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
ktoso
force-pushed
the
wip-jextract-plugin
branch
25 times, most recently
from
654d0a2 to
dc0a2c3
Compare
ktoso
force-pushed
the
wip-jextract-plugin
branch
from
cd67ec6 to
358bc50
Compare
We now heavily rely on Swift thunk generation and call into those C calling convention compatible APIs from Java. They translate into member calls on classes -- this way we'll be able to also do structs and other things. This also introduces gradle to "drive" the `swift package jextract` plugin. This allows us for samples to be a plain `./gradlew run`, and no more manual running of any make or other swift interface generation steps etc. This is a big milestone towards getting "just works" builds with the jextract route. Follow ups will handle more java library path handling and more types of calls we can make, like variables, and importing structs etc.
This reverts commit 0f4002d.
working on samples validation fixed name deduplication logic
Change how we do static initialization, to automatically load library as we first use a class from it! rename verify step fix variable import test for new scheme gitignore .d and similar files split out samples into separate job ci: reorganize jobs include objc workaround for linux dont rebuild twice to get better output build dependency fixes in gradle: depend on SwiftKit as well lib paths: workaround for swiftly installed 6.0.2 lib path ignore .idea directory
Correct reference counting in init thunk lots of fixing around how we deal with config and library loading move trace functions into SwiftKit; avoid regenerating adjust swift source gen tests
ktoso
force-pushed
the
wip-jextract-plugin
branch
from
7def075 to
7df2a33
Compare
ktoso
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesign jextract-swift: plugins and avoid custom swift features
We now heavily rely on Swift thunk generation and call into those C
calling convention compatible APIs from Java. They translate into member
calls on classes -- this way we'll be able to also do structs and other
things.
This also introduces gradle to "drive" the
swift package jextractplugin. This allows us for samples to be a plain
./gradlew run,and no more manual running of any make or other swift interface
generation steps etc.
This is a big milestone towards getting "just works" builds with the
jextract route.
Follow ups will handle more java library path handling and more types of
calls we can make, like variables, and importing structs etc.