Syntax and parsing for '-define-availability' argument #2954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
approved these changes
Feb 4, 2025
Comment on lines
23
to
27
| for node in NON_BASE_SYNTAX_NODES { | ||
| if let spi = node.spi, seen.insert(spi.text).inserted { | ||
| AttributeSyntax("@_spi(\(spi))").with(\.trailingTrivia, .space) | ||
| } | ||
| } |
There was a problem hiding this comment.
This is repeated at least 3 times. Could we share it?
| @@ -13,9 +13,9 @@ | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| #if compiler(>=6) | |||
| @_spi(RawSyntax) public import SwiftSyntax | |||
| @_spi(RawSyntax) @_spi(ExperimentalLanguageFeatures) @_spi(Compiler) public import SwiftSyntax | |||
There was a problem hiding this comment.
Suggested change
| @_spi(RawSyntax) @_spi(ExperimentalLanguageFeatures) @_spi(Compiler) public import SwiftSyntax | |
| @_spi(RawSyntax) @_spi(ExperimentalLanguageFeatures) @_spi(Compiler) public import SwiftSyntax |
rintaro
force-pushed
the
availability-macro-definition
branch
from
7ae0295 to
923a242
Compare
|
@swift-ci Please test |
ahoppen
reviewed
Feb 4, 2025
| internal import SwiftSyntax | ||
| @_spi(RawSyntax) @_spi(ExperimentalLanguageFeatures) @_spi(Compiler) public import SwiftSyntax |
There was a problem hiding this comment.
The import access level changed here.
There was a problem hiding this comment.
Made it .internal by default
rintaro
force-pushed
the
availability-macro-definition
branch
2 times, most recently
from
7830845 to
624fde6
Compare
Under 'Compier' SPI. This is for parsing arguments for '-define-availability' compiler option: <identifier> <version-tuple>? ':' <availability-spec-list>
Import all known @_spi.
rintaro
force-pushed
the
availability-macro-definition
branch
from
624fde6 to
a1c17fe
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.