Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop '#if compiler(>=5.8)' guards #2956

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Feb 5, 2025

swift-syntax does not support pre-5.8 compilers anymore. #if compiler(>=5.8) guards are meaningless.

@rintaro
Copy link
Member Author

rintaro commented Feb 5, 2025

@swift-ci Please test

swift-syntax does not support pre-5.8 compilers anymore.
`#if compiler(>=5.8)` guards are meaningless.
@rintaro
Copy link
Member Author

rintaro commented Feb 5, 2025

@swift-ci Please test

@rintaro rintaro marked this pull request as ready for review February 5, 2025 12:08
@rintaro
Copy link
Member Author

rintaro commented Feb 5, 2025

@swift-ci Please test Windows

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@rintaro rintaro enabled auto-merge February 5, 2025 15:15
@rintaro rintaro merged commit d8ca62d into swiftlang:main Feb 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants