Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SwiftParser] Use raw.arena instead of parser.arena to construct Syntax #2957

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Feb 5, 2025

RawSyntax.arena is not necessarility the same instance as the parsing arena

rdar://144177851

@rintaro rintaro force-pushed the raw-arena-rdar144177851 branch from 87e0a92 to f2800d7 Compare February 5, 2025 06:44
@rintaro
Copy link
Member Author

rintaro commented Feb 5, 2025

@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented Feb 5, 2025

@swift-ci Please test Windows

RawSyntax.arena is not necessarility the same instance as the parsing
arena

rdar://144177851
@rintaro rintaro force-pushed the raw-arena-rdar144177851 branch from f2800d7 to f315db6 Compare February 5, 2025 12:01
@rintaro
Copy link
Member Author

rintaro commented Feb 5, 2025

@swift-ci Please test

@rintaro rintaro marked this pull request as ready for review February 5, 2025 12:01
@rintaro
Copy link
Member Author

rintaro commented Feb 5, 2025

@swift-ci Please test

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rintaro rintaro enabled auto-merge February 5, 2025 15:15
@rintaro rintaro merged commit 081fc7e into swiftlang:main Feb 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants