[ASTGen] Generate CaptureListExpr #79416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
hborla,
slavapestov and
xedin
as code owners
rintaro
force-pushed
the
astgen-capturelistexpr
branch
from
9deaa80 to
5376bc1
Compare
rintaro
commented
Feb 16, 2025
| parameters: BridgedArrayRef(), | ||
| rightParenLoc: nil | ||
| ) | ||
| result.params = nil |
There was a problem hiding this comment.
Creating empty parameter list here was a mistake. generate(closureExpr:) will synthesize anonymous closure parameter list according to the $n usages.
rintaro
force-pushed
the
astgen-capturelistexpr
branch
from
5376bc1 to
c6e94b6
Compare
Move the capture list entry construction logic to CaptureListEntry::createParsed() so that ASTGen can use it.
rintaro
force-pushed
the
astgen-capturelistexpr
branch
from
c6e94b6 to
84875d1
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
hamishknight
approved these changes
Feb 16, 2025
Comment on lines
235
to
+236
| let captures = node.items.lazy.map { node in | ||
| self.generate(closureCapture: node) | ||
| self.generate(closureCapture: node, capturedSelfDecl: &result.capturedSelfDecl) |
There was a problem hiding this comment.
Using an inout argument in a lazy transform feels like it has the potential to be a footgun, though I guess it doesn't really matter in practice given we know bridgedArray immediately iterates in order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the capture list entry construction logic to
CaptureListEntry::createParsed()so that ASTGen can use it.