Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse: Avoid including DiagnosticsParse.h in Parser.h #79480

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Parse: Avoid including DiagnosticsParse.h in Parser.h #79480

merged 1 commit into from
Feb 20, 2025
+31 −24

Conversation

tshortli
Copy link
Contributor

This prevents the include of DiagnosticsParse.h from leaking into .cpp files in libraries besides Parse.

@tshortli
Copy link
Contributor Author

@swift-ci please smoke test

@tshortli tshortli enabled auto-merge February 19, 2025 06:42
@tshortli
Parse: Avoid including DiagnosticsParse.h in Parser.h.
e8329d2 
This prevents the include of DiagnosticsParse.h from leaking into `.cpp` files
in libraries besides Parse.
@tshortli tshortli force-pushed the exclude-parser-diags branch from db03939 to e8329d2 Compare February 19, 2025 15:56
@tshortli
Copy link
Contributor Author

@swift-ci please smoke test

@tshortli
Copy link
Contributor Author

@swift-ci please smoke test Linux

@tshortli
Copy link
Contributor Author

@swift-ci please smoke test Windows

@tshortli tshortli merged commit ff17263 into swiftlang:main Feb 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rintaro rintaro rintaro approved these changes

@hamishknight hamishknight hamishknight approved these changes

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@jckarter jckarter Awaiting requested review from jckarter jckarter is a code owner

@ahoppen ahoppen Awaiting requested review from ahoppen ahoppen is a code owner

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@CodaFi CodaFi Awaiting requested review from CodaFi CodaFi is a code owner

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tshortli @rintaro @hamishknight