[AST] Sink ParamDecl flag collection logic from Parse to AST #79503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
ahoppen,
bnbarham,
CodaFi,
hamishknight,
hborla,
slavapestov,
xedin and
DougGregor
as code owners
rintaro
commented
Feb 20, 2025
| @@ -276,7 +275,6 @@ extension ASTGenVisitor { | |||
| params.reserveCapacity(node.parameters.count) | |||
| for (index, node) in node.parameters.enumerated() { | |||
| let param = self.generate(closureParameter: node, at: index) | |||
| param.setSpecifier(.default) | |||
There was a problem hiding this comment.
This line was a mistake because this set the closure parameter specifier to .default even if the TypeRepr has been set. So closures like { (arg: inout T) in .. } wasn't correctly generated.
|
@swift-ci Please smoke test |
rintaro
changed the title
hamishknight
approved these changes
Feb 20, 2025
| @@ -8712,6 +8712,45 @@ ParamDecl *ParamDecl::createParsed( | |||
| return decl; | |||
| } | |||
|
|
|||
| void ParamDecl::setTypeRepr(TypeRepr *repr) { | |||
| TyReprAndFlags.setPointer(repr); | |||
There was a problem hiding this comment.
Can we assert that the type repr hasn't been set before?
* Collect flag in `ParamDecl::setTypeRepr()`. * [ASTGen] Separate `BridgedParamDecl.setTypeRepr(_:)` from `BridgedParamDecl.createParsed(_:)` aligning with C++ API. The majority of the creations don't set the typerepr. * Update `ParamSpecifierRequest::evaluate` to handle non-implicit `ParamDecl` without `TypeRepr` (i.e. untyped closure parameter), instead of `setSpecifier(::Default)` manually in Parse.
rintaro
force-pushed
the
astgen-paramdecl-typerepr
branch
from
86f421a to
8833ff5
Compare
|
@swift-ci Please smoke test |
|
swiftlang/swift-corelibs-foundation#5174 |
|
@swift-ci Please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect flags in
ParamDecl::setTypeRepr().Update
ParamSpecifierRequest::evaluateto handle non-implicitParamDeclwithoutTypeRepr(i.e. untyped closure parameter), instead ofsetSpecifier(::Default)manually in Parse.(ASTGen) Separate
BridgedParamDecl.setTypeRepr(_:)fromBridgedParamDecl.createParsed(_:)aligning with C++ API. The majority of the creations don't set the typerepr.