Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASTGen] Assorted fixes #79544

Merged
merged 3 commits into from
Feb 24, 2025
Merged

[ASTGen] Assorted fixes #79544

merged 3 commits into from
Feb 24, 2025

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Feb 21, 2025

  • Wrap optional binding pattern with type annotation if exist. e.g. if let x: Int = optionalInt. Previously the type annotation was ignored.
  • Trailing where clause for SubscriptDecl. Peviously it was just missing
  • Generate ErrorTypeRepr from MissingTypeSyntax.

@rintaro
Copy link
Member Author

rintaro commented Feb 21, 2025

@swift-ci Please smoke test

@rintaro
Copy link
Member Author

rintaro commented Feb 22, 2025

@swift-ci Please smoke test Windows

1 similar comment
@rintaro
Copy link
Member Author

rintaro commented Feb 22, 2025

@swift-ci Please smoke test Windows

@rintaro rintaro merged commit af489ea into swiftlang:main Feb 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishknight hamishknight hamishknight approved these changes

@ahoppen ahoppen Awaiting requested review from ahoppen ahoppen is a code owner

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@CodaFi CodaFi Awaiting requested review from CodaFi CodaFi is a code owner

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @hamishknight