Notify build is preparing before progress starts #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build progress notification would only appear once the progress values were shown in the output, i.e. [12/122]. Until progress values appear, show a "Preparing <task>" notification. This only needs to apply when the `showBuildStatus` value is `notification` or `progress`, since `swiftStatus` already shows a message in the bar immediately. This patch also only sets the `showBuildStatus` setting on a Task if it is coming from a user defined task. Previously it was being set on synthetic tasks which were being cached, so when the user updated the `showBuildStatus` setting it wouldn't take effect until they restarted the extension. Issue: swiftlang#1322
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
|
cc @MahdiBM |
MahdiBM
approved these changes
Jan 21, 2025
award999
reviewed
Jan 21, 2025
award999
approved these changes
Jan 21, 2025
plemarquand
added a commit
to plemarquand/vscode-swift
that referenced
this pull request
Jan 23, 2025
Previously we were waiting for output from the build, which could be several seconds. Issue: swiftlang#1323
award999
pushed a commit
that referenced
this pull request
Jan 23, 2025
* Show build preparing status immediately Previously we were waiting for output from the build, which could be several seconds. Issue: #1323 * Fixup test
plemarquand
added a commit
to plemarquand/vscode-swift
that referenced
this pull request
Jan 23, 2025
award999
pushed a commit
that referenced
this pull request
Jan 23, 2025
|
Verified with fa4d12c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build progress notification would only appear once the progress values were shown in the output, i.e. [12/122]. Until progress values appear, show a "Preparing " notification. This only needs to apply when the
showBuildStatusvalue isnotificationorprogress, sinceswiftStatusalready shows a message in the bar immediately.This patch also only sets the
showBuildStatussetting on a Task if it is coming from a user defined task. Previously it was being set on synthetic tasks which were being cached, so when the user updated theshowBuildStatussetting it wouldn't take effect until they restarted the extension.Issue: #1322