Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit 10 Shift #8

Merged
merged 10 commits into from
Mar 28, 2024
Merged

PHPUnit 10 Shift #8

merged 10 commits into from
Mar 28, 2024

Conversation

JaZo
Copy link
Member

@JaZo JaZo commented Mar 28, 2024

This pull request contains changes for upgrading to PHPUnit 10 automated by the PHPUnit 10 Shift.

Before merging, you need to:

  • Checkout the shift-114256 branch
  • Review all pull request comments for additional changes
  • Run composer update (if the scripts fail, try with --no-scripts)
  • Run your tests suite: vendor/bin/phpunit

If there were changes you felt could have been automated, please reply to the follow-up email with your feedback or on Twitter.

@JaZo
Copy link
Member Author

JaZo commented Mar 28, 2024

⚠️ PHPUnit 10 has made several changes to the configuration file. After running composer update, you may run vendor/bin/phpunit --migrate-configuration to have PHPUnit upgrade your configuration file.

@JaZo
Copy link
Member Author

JaZo commented Mar 28, 2024

❌ The setMethods method on the MockBuilder was deprecated in PHPUnit 8 and removed in PHPUnit 10. Instead, you may use onlyMethods to mock methods which exist and addMethods to mock methods which do not exist.

Shift detected calls to setMethods in the following files:

  • tests/ResponseFactoryTest.php

@JaZo JaZo merged commit 806ea6d into master Mar 28, 2024
8 of 9 checks passed
@JaZo JaZo deleted the shift-114256 branch March 28, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants