fix keep alive when not use pool #38
Merged
+71
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
close #37 |
ihipop
changed the title
|
之所以在单元测试里面加上了httpd.而不是用mixed是因为mixed用的swoole 的web socket server ，可能是By Design，在我的swoole 4.3.2版本下，连击一次以后会被强制断开导致长测试不能通过。 |
|
粗略看了下没有问题，明天有空再仔细看看，没有你所说的设计，这里可能存在误区。 |
@twose |
twose
reviewed
May 17, 2019
|
和我想象的不太一样, 但先merge了, release之前我会再做更多检查 |
twose
added
enhancement
twose
added a commit
that referenced
this pull request
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
写了单元测试，ALL PASSED
待Review @twose