Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more modern ImGui input API #1

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

psyGamer
Copy link
Contributor

The main reasoning behind this is that the old API doesn't work well with the mouse position when the window isn't in full screen, causing desyncs between the actual mouse position and the position ImGui thinks where the mouse is.

@swoolcock
Copy link
Owner

Ok re: our Discord discussion, I didn't realise you had solved the problem by actually rewriting the input system I was originally complaining about. 🤦
I'll take a look at this and maybe update imgui in the process (or in another PR). Note that an imgui update will be a breaking change for the like 2 mods that use it.

@swoolcock
Copy link
Owner

Code looks fine, will look at doing a release this weekend. I'll probably need to coordinate with Ja so that MappingUtils works immediately.

@swoolcock swoolcock merged commit b4fb450 into swoolcock:main Aug 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants