-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle and lint plugins #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ready for review :) |
hirasso
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍰
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
build
andlint
commands, previously part of@swup/plugin
UI
Polished up the UI a bit using interactive task lists.
Screen.Recording.2023-09-14.at.10.58.28.mov
Bundling packing
All bundling, linting, formatting functionality is grouped in a
package:*
topic. The functionality is exactly the same as the current implementation in@swup/plugin
.Creating plugins
The
--type
arg is no longer required if it can be inferred from the name:Validating sites
The
--crawl
argument is now a flag and re-uses the base URL.Config file
The config file used for storing some of the validation information is now loaded using cosmiconfig, so that any of these are possible locations for the configuration:
swup
key inpackage.json
swup.config.js
file (as before).swuprc.json
,.swuprc.yml
,.swuprc.js
,.swuprc.mjs
, or.swuprc.cjs
fileswup.config.js
,swup.config.mjs
, orswup.config.cjs
fileInterestingly, the config file was never described in the readme, so not sure how to go about documenting this.
Checks
master
branchnpm run lint
)All tests are passing (npm run test
)New or updated tests are includedAdditional information
Closes #19
Closes #23
Closes #24