Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore external links on hover #119

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Ignore external links on hover #119

merged 1 commit into from
Jan 26, 2024

Conversation

hirasso
Copy link
Member

@hirasso hirasso commented Jan 26, 2024 •
edited
Loading

Fixes #118
Replaces swup/swup#867

@hirasso hirasso mentioned this pull request Jan 26, 2024
Closed
2 tasks
@github-actions GitHub Actions
Copy link

Playwright test results

passed  68 passed
skipped  4 skipped

Details

stats  72 tests across 7 suites
duration  1 minute, 10 seconds
commit  e31e218

Skipped tests

chromium → preload-plugin.spec.ts → active links → preloads links on touchstart
firefox → preload-plugin.spec.ts → active links → preloads links on touchstart
webkit → preload-plugin.spec.ts → active links → preloads links on touchstart
ios → preload-plugin.spec.ts → active links → preloads links on hover

@hirasso hirasso merged commit 5b231c7 into master Jan 26, 2024
2 checks passed
@hirasso hirasso deleted the fix/ignore-external-urls branch January 26, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daun daun daun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: External links are not being properly ignored on hover
2 participants
@hirasso @daun