Fix flaky tests

[hirasso]

Description

Something is wrong with the CI:

• It failed when I merged the latest dependabot PR
• after I pulled the current master to my local machine, I sometimes got an error for the test allows for custom queue size

I'm creating this PR just to test what's wrong.

Checks

• The PR is submitted to the master branch

[github-actions]

Playwright test results

 88 passed
 4 skipped

Details

 92 tests across 8 suites
 
 5c38bd7

Skipped tests

chromium → preload-plugin.spec.ts → active links → preloads links on touchstart
firefox → preload-plugin.spec.ts → active links → preloads links on touchstart
webkit → preload-plugin.spec.ts → active links → preloads links on touchstart
ios → preload-plugin.spec.ts → active links → preloads links on hover

[hirasso]

...seems to be working alright... @daun, I can't make sense of the test that was failing:

preload-plugin/tests/unit/queue.test.ts

Lines 59 to 77 in 84b4418

	it('allows custom queue size', async () => {
	let size = 5;
	let items = 5;
	let duration = 100;
	let elapsed = 0;
	const { add, next } = createQueue(size);
	const timer = createTimer();
	const test = () => sleep(duration).then(() => (elapsed = timer())).then(next);
	for (let i = 0; i < items; i++) {
	add(() => test()); // add different function with each iteration = sequential
	}
	await sleep((items + 1) * duration);
	const [min, max] = pad(items * duration / size);
	expect(elapsed).to.be.gte(min);
	expect(elapsed).to.be.lte(max);
	});
	});

Would you like to explain what exactly it is testing? Alternatively, some code comments could help our future selfs.

[daun]

What‘s the error you‘re getting locally?

The particular test tries to confirm that the priority queue can have a custom length (i.e. preload max 5 links at once).

[hirasso]

Yesterday, elapsed also was was 104 instead of 106, once

[daun]

Alright, so we‘ll need to add some slack around the number checks I guess?

[hirasso]

Yes! I think increasing the padding in pad could help. As I don't understand exactly how this is supposed to work, I'd be grateful if you would take care of it.

[daun]

Looking good now :)

[hirasso]

👌