Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow choice of reading Pi and Phi from numeric ID #6430

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Jan 7, 2025

Or setting them based on the 1- and 3-index constraints. Only works for numeric ID from GH vars. Numeric ID from ADM vars still computes phi with numerical derivatives.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

support/Pipelines/Bbh/Ringdown.yaml Show resolved Hide resolved
"numerical derivative of SpacetimeMetric, to enforce the 3-index "
"constraint.";
"constraint and Pi is set using the 1-index constraint. Otherwise, "
"they are read in from the numeric ID.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that Pi is always read from numeric ID, then modified to transform to the evolution gauge if SetPiAndPhiFromConstraints is true

nilsdeppe
nilsdeppe previously approved these changes Jan 7, 2025
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! Thanks for doing this!!

The only possible thing we may want is the ability to set only pi, only phi, both, or none. However, I think that's beyond the scope of this PR and can be delayed until we need it. Probably the easiest way to generalize is to change the tag type from a bool to an enum with different states.

@knelli2
Copy link
Contributor Author

knelli2 commented Jan 10, 2025

Updated after discussions with @nilsvu. Decided that if we are reading GH numeric data, then we won't need to set Pi and Phi at all. Examples being PB&J and Ringdown. And if we are using ADM variables, we'll need to set Pi to work with the evolution gauge and set Phi to satisfy constraints. So I removed the option in the input file and now we just always set Pi and Phi from constraints unless we are using GH numeric ID

@knelli2 knelli2 force-pushed the no_pi_phi_constraints branch from 6c464f0 to 67c5db9 Compare January 10, 2025 00:42
Mutators run with MutateApply weren't able to add simple or cache tags,
now they are.
Or setting them based on the 1- and 3-index constraints. Only works for
numeric ID from GH vars. Numeric ID from ADM vars still computes phi
with numerical derivatives.
@nilsvu nilsvu enabled auto-merge January 10, 2025 20:27
@nilsvu nilsvu merged commit 199a164 into sxs-collaboration:develop Jan 10, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants