-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow choice of reading Pi and Phi from numeric ID #6430
Allow choice of reading Pi and Phi from numeric ID #6430
Conversation
"numerical derivative of SpacetimeMetric, to enforce the 3-index " | ||
"constraint."; | ||
"constraint and Pi is set using the 1-index constraint. Otherwise, " | ||
"they are read in from the numeric ID."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that Pi is always read from numeric ID, then modified to transform to the evolution gauge if SetPiAndPhiFromConstraints
is true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!! Thanks for doing this!!
The only possible thing we may want is the ability to set only pi, only phi, both, or none. However, I think that's beyond the scope of this PR and can be delayed until we need it. Probably the easiest way to generalize is to change the tag type from a bool to an enum with different states.
45792c1
to
6c464f0
Compare
Updated after discussions with @nilsvu. Decided that if we are reading GH numeric data, then we won't need to set Pi and Phi at all. Examples being PB&J and Ringdown. And if we are using ADM variables, we'll need to set Pi to work with the evolution gauge and set Phi to satisfy constraints. So I removed the option in the input file and now we just always set Pi and Phi from constraints unless we are using GH numeric ID |
6c464f0
to
67c5db9
Compare
src/Evolution/Systems/GeneralizedHarmonic/Actions/SetInitialData.hpp
Outdated
Show resolved
Hide resolved
Mutators run with MutateApply weren't able to add simple or cache tags, now they are.
Or setting them based on the 1- and 3-index constraints. Only works for numeric ID from GH vars. Numeric ID from ADM vars still computes phi with numerical derivatives.
67c5db9
to
c06c1ff
Compare
Or setting them based on the 1- and 3-index constraints. Only works for numeric ID from GH vars. Numeric ID from ADM vars still computes phi with numerical derivatives.
Proposed changes
Upgrade instructions
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments