Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for Python 3.9 #6443

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Fix CI for Python 3.9 #6443

merged 1 commit into from
Jan 17, 2025

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Jan 17, 2025

Proposed changes

Because our containers are Ubuntu 22.04 and the actions/setup-python@v5 action was pulling python3.9 built for 24.04, there was a GLIBC version mismatch. Here we just pull from deadsnakes instead.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@knelli2 knelli2 added bugfix ci/cd Continuous integration & deployment labels Jan 17, 2025
@knelli2 knelli2 requested a review from nilsvu January 17, 2025 05:21
with:
python-version: ${{ matrix.PYTHON_VERSION }}
run: |
apt install -y software-properties-common
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already installed

@nilsvu nilsvu enabled auto-merge January 17, 2025 05:26
@nilsvu nilsvu merged commit 75c5b62 into sxs-collaboration:develop Jan 17, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix ci/cd Continuous integration & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants