Refactor how we define the available locales #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Apr 11, 2024
javiereguiluz
force-pushed
the
refactor_locales
branch
from
3b9b379 to
2955454
Compare
|
best part is no part 👍🏻 |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Apr 23, 2024
…description (javiereguiluz) This PR was merged into the 5.4 branch. Discussion ---------- [FrameworkBundle][Routing] Update the `enabled_locales` description While working on symfony/demo#1511 I found this feature, which works since Symfony 5.4. See: https://github.com/symfony/symfony/blob/184597db05288c68c9eb11dff55239768268f646/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php#L1083-L1086 Commits ------- c9b92b3 [FrameworkBundle] Update the enabled_locales description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I never liked the
app_localesparameter: https://github.com/symfony/demo/blob/main/config/services.yaml#L9But we need it for the route locale requirements.
I was digging into how to improve this ... and realized that if we use the standard enabled_locales config option from Symfony, the
{_locale}parameter included in the URLs is automatically restricted to those values.So, we can simplify code by moving to
enabled_localeswithout losing any functionality.