Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove User instance check #19800

Closed
wants to merge 1 commit into from
Closed

Remove User instance check #19800

wants to merge 1 commit into from

Conversation

hbgamra
Copy link
Contributor

@hbgamra hbgamra commented Apr 18, 2024

The check is already did in supportsClass() function

@hbgamra
Remove User instance check
126bc59 
The check is already did in supportsClass() function
@OskarStark
Copy link
Contributor

True but this message could be called without calling support first, so let's keep it

@OskarStark OskarStark requested a review from xabbuh April 19, 2024 12:41
@xabbuh
Copy link
Member

xabbuh commented Apr 19, 2024

I agree, I would rather be defensive here.

@OskarStark
Copy link
Contributor

Thanks for proposing

@OskarStark OskarStark closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hbgamra @OskarStark @xabbuh @carsonbot