Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Form] Update enum.rst: Adding choice_label #20387

Merged
merged 1 commit into from
Feb 3, 2025
Merged

[Form] Update enum.rst: Adding choice_label #20387

merged 1 commit into from
Feb 3, 2025

Conversation

ThomasLandauer
Copy link
Contributor

@carsonbot carsonbot added this to the 5.4 milestone Nov 11, 2024
@xabbuh
Copy link
Member

xabbuh commented Nov 27, 2024 •
edited
Loading

Shouldn't we also add the other choice_* options?

@ThomasLandauer
Copy link
Contributor Author

ThomasLandauer commented Nov 27, 2024 •
edited
Loading

OK, I copied everything called "choice_*" - but please doublecheck if they really exist at an EnumType ;-)

@xabbuh xabbuh modified the milestones: 5.4, 6.4 Dec 16, 2024
@javiereguiluz javiereguiluz changed the base branch from 5.4 to 6.4 February 3, 2025 11:33
@javiereguiluz
Copy link
Member

Thanks Thomas!

@javiereguiluz javiereguiluz merged commit 21dffc6 into symfony:6.4 Feb 3, 2025
3 checks passed
@ThomasLandauer ThomasLandauer deleted the patch-18 branch February 3, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ThomasLandauer @xabbuh @javiereguiluz @carsonbot