Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Laravel 11 #10

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Update to Laravel 11 #10

merged 2 commits into from
Mar 14, 2024

Conversation

eshimischi
Copy link
Contributor

No description provided.

composer.json Outdated Show resolved Hide resolved
Co-authored-by: Benedikt Franke <[email protected]>
@TomasVotruba TomasVotruba merged commit c3cd614 into symplify:main Mar 14, 2024
6 checks passed
@TomasVotruba
Copy link
Member

Thanks 👍

@eshimischi eshimischi deleted the patch-1 branch March 14, 2024 11:04
@eshimischi
Copy link
Contributor Author

Would you please release it as new tag? https://github.com/symplify/rule-doc-generator/tags

@TomasVotruba
Copy link
Member

This package should have downgraded release instead of locking version and releasing a new tag for every bump.
Just noticed it's not the case. We'll need to fix that first :)

@eshimischi
Copy link
Contributor Author

eshimischi commented Mar 14, 2024

I meant this pull353 in order to receive new laravel 11 compatible package version should be upgraded or not?

@TomasVotruba
Copy link
Member

Indeed, but we need to fix this propperly using downgrade releases as in other packages. Otherwise we might get another package change, that would force a new release, which is non-sense for tools.

Comment on lines 17 to 18
"symfony/yaml": "^6.4",
"symfony/filesystem": "^6.4"
Copy link

@owenvoke owenvoke Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these need to be updated to support Symfony 7, as Laravel 11 depends uses it? 🤔

Ah, I guess it'd be resolved by #11 👍🏻 Ignore me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well i checked this package on my project which updated to Laravel 11 and both packages have version 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants