fix:

- different default slippage settings - use same slippage for quote and bridge in Intents
synapsecns · Feb 4, 2025 · 25aaaff · 25aaaff
1 parent d34a59a
commit 25aaaff
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 9 deletions.
diff --git a/packages/sdk-router/src/module/synapseModuleSet.ts b/packages/sdk-router/src/module/synapseModuleSet.ts
@@ -175,8 +175,8 @@ export abstract class SynapseModuleSet {
   abstract applySlippage(
     originQueryPrecise: Query,
     destQueryPrecise: Query,
-    slipNumerator: number,
-    slipDenominator: number
+    slipNumerator?: number,
+    slipDenominator?: number
   ): { originQuery: Query; destQuery: Query }
 
   /**

diff --git a/packages/sdk-router/src/operations/bridge.ts b/packages/sdk-router/src/operations/bridge.ts
@@ -219,7 +219,7 @@ export function applyBridgeDeadline(
 
 /**
  * Applies slippage to the given bridge queries, according to bridge module's slippage tolerance.
- * Note: default slippage is 10 bips (0.1%).
+ * Note: default slippage is 100 bips (1%) for SynapseIntents and 10 bips (0.1%) for all other modules.
  *
  * @param bridgeModuleName - The name of the bridge module.
  * @param originQueryInitial - The query for the origin chain, coming from `allBridgeQuotes()`.
@@ -233,8 +233,8 @@ export function applyBridgeSlippage(
   bridgeModuleName: string,
   originQueryInitial: Query,
   destQueryInitial: Query,
-  slipNumerator: number = 10,
-  slipDenominator: number = 10000
+  slipNumerator?: number,
+  slipDenominator?: number
 ): { originQuery: Query; destQuery: Query } {
   const moduleSet = getModuleSet.call(this, bridgeModuleName)
   return moduleSet.applySlippage(

diff --git a/packages/sdk-router/src/rfq/engine/swapEngine.ts b/packages/sdk-router/src/rfq/engine/swapEngine.ts
@@ -40,6 +40,7 @@ export type Slippage = {
 }
 
 // Max slippage that can be used by the swap engines, 100 bips (1%)
+// TODO: consider lowering this value
 export const SlippageMax: Slippage = {
   numerator: 100,
   denominator: 10000,

diff --git a/packages/sdk-router/src/rfq/sirSet.ts b/packages/sdk-router/src/rfq/sirSet.ts
@@ -44,6 +44,7 @@ import {
   RecipientEntity,
   validateEngineID,
   Slippage,
+  SlippageMax,
   applySlippage,
   SwapEngineQuote,
   RouteInput,
@@ -245,8 +246,8 @@ export class SynapseIntentRouterSet extends SynapseModuleSet {
   public applySlippage(
     originQueryPrecise: Query,
     destQueryPrecise: Query,
-    slipNumerator: number,
-    slipDenominator: number
+    slipNumerator: number = SlippageMax.numerator,
+    slipDenominator: number = SlippageMax.denominator
   ): { originQuery: Query; destQuery: Query } {
     // We should have saved neccessary params within dstQuery.rawParams
     if (hexDataLength(destQueryPrecise.rawParams) === 0) {

diff --git a/packages/sdk-router/src/router/routerSet.ts b/packages/sdk-router/src/router/routerSet.ts
@@ -197,8 +197,8 @@ export abstract class RouterSet extends SynapseModuleSet {
   public applySlippage(
     originQueryPrecise: Query,
     destQueryPrecise: Query,
-    slipNumerator: number,
-    slipDenominator: number
+    slipNumerator: number = 10,
+    slipDenominator: number = 10000
   ): { originQuery: Query; destQuery: Query } {
     return {
       originQuery: applySlippageToQuery(