Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump harmony commit hash [goreleaser] #3503

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

ChiTimesChi
Copy link
Collaborator

@ChiTimesChi ChiTimesChi commented Feb 4, 2025

Description
A clear and concise description of the features you're adding in this pull request.

Additional context
Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

Summary by CodeRabbit

  • Chores
    • Updated the Harmony protocol integration to support the latest version release in 2025.

@ChiTimesChi ChiTimesChi requested a review from trajan0x as a code owner February 4, 2025 17:54
Copy link
Contributor

coderabbitai bot commented Feb 4, 2025

Walkthrough

The pull request updates the Harmony proxy module's expected version constant. The constant expectedVersion in the file is modified from a 2023 version string to a 2025 version string, indicating a protocol revision. No other changes to logic, method signatures, or control flow are present.

Changes

File Change Summary
services/.../harmonyproxy.go Updated expectedVersion constant from "Harmony (C) 2023. harmony, version v8421-v2024.3.0-0-g2e824e126" to "Harmony (C) 2025. harmony, version v8507-v2025.0.0-0-ga63980b98"

Possibly related PRs

Suggested labels

go, size/xs, needs-go-generate-services/rfq

Suggested reviewers

  • trajan0x

Poem

I'm a sprightly rabbit in a coding glade,
Hopping over constants with upgrades displayed.
From 2023 to 2025, a version leap so bold,
In harmony's proxy, a new tale is told.
With each little change, the code sings and thrives!
🐇✨

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 35f9ea4 and 0372bd3.

📒 Files selected for processing (1)
  • services/omnirpc/modules/harmonyproxy/harmonyproxy.go (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • services/omnirpc/modules/harmonyproxy/harmonyproxy.go
⏰ Context from checks skipped due to timeout of 90000ms (15)
  • GitHub Check: Go Coverage (1.22.x, services/scribe)
  • GitHub Check: Go Coverage (1.22.x, services/rfq)
  • GitHub Check: Go Coverage (1.22.x, services/explorer)
  • GitHub Check: Go Generate (Module Changes) (services/scribe)
  • GitHub Check: Go Generate (Module Changes) (services/rfq)
  • GitHub Check: Go Coverage (1.22.x, services/cctp-relayer)
  • GitHub Check: Go Generate (Module Changes) (services/omnirpc)
  • GitHub Check: Go Coverage (1.22.x, contrib/promexporter)
  • GitHub Check: Go Generate (Module Changes) (services/explorer)
  • GitHub Check: Go Coverage (1.22.x, contrib/opbot)
  • GitHub Check: Go Generate (Module Changes) (services/cctp-relayer)
  • GitHub Check: Go Generate (Module Changes) (contrib/promexporter)
  • GitHub Check: Go Generate (Module Changes) (contrib/opbot)
  • GitHub Check: Go Generate (Module Changes) (agents)
  • GitHub Check: Build (1.22.x)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added go Pull requests that update Go code size/xs labels Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.56034%. Comparing base (2847b63) to head (0372bd3).
Report is 4 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (2847b63) and HEAD (0372bd3). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (2847b63) HEAD (0372bd3)
solidity 1 0
Additional details and impacted files
@@                 Coverage Diff                  @@
##              master       #3503          +/-   ##
====================================================
- Coverage   98.89241%   10.56034%   -88.33207%     
====================================================
  Files             11         288         +277     
  Lines            632       28768       +28136     
====================================================
+ Hits             625        3038        +2413     
- Misses             7       25304       +25297     
- Partials           0         426         +426     
Flag Coverage Δ
cctp-relayer 31.97848% <ø> (?)
explorer 4.93656% <ø> (?)
omnirpc 32.65401% <ø> (?)
opbot 0.18282% <ø> (?)
promexporter 6.81642% <ø> (?)
scribe 18.24614% <ø> (?)
solidity ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0372bd3
Status: ✅  Deploy successful!
Preview URL: https://49cdbc65.sanguine-fe.pages.dev
Branch Preview URL: https://fix-harmony-8507.sanguine-fe.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants