Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactor #333

Open
wants to merge 2 commits into
base: release
Choose a base branch
from
Open

Code refactor #333

wants to merge 2 commits into from

Conversation

GermanAizek
Copy link

@GermanAizek GermanAizek commented Oct 22, 2021

@syoyo
Strings replaced by characters where possible, initializing object variables in the constructor, default constructors and destructors, using std::move, and deleting unused code.

@syoyo
Copy link
Owner

syoyo commented Oct 23, 2021

You should describe details of this PR

@GermanAizek
Copy link
Author

@syoyo updated details of this PR

@GermanAizek
Copy link
Author

Dear @syoyo, check it again.

@syoyo syoyo added the trivial label Oct 27, 2021
@syoyo
Copy link
Owner

syoyo commented Oct 27, 2021

@GermanAizek Changes seem marginal and unimportant, so may not merge this PR

@GermanAizek
Copy link
Author

@syoyo, review new commit again.

@syoyo
Copy link
Owner

syoyo commented Oct 27, 2021

@GermanAizek Please create new PR for Fixed possible overflow CWE-190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants