logproto: remove handshake in progress #5170
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build FAILURE |
HofiOne
changed the title
HofiOne
force-pushed
the
logproto-remove-handshake-in-progress
branch
from
c248a07 to
9fd0c48
Compare
|
Build FAILURE |
HofiOne
force-pushed
the
logproto-remove-handshake-in-progress
branch
2 times, most recently
from
cd68768 to
809b772
Compare
HofiOne
force-pushed
the
logproto-remove-handshake-in-progress
branch
from
809b772 to
9a2e1df
Compare
HofiOne
force-pushed
the
logproto-remove-handshake-in-progress
branch
from
9a2e1df to
6d7be36
Compare
|
Build FAILURE |
Instead of having to call an extra virtual method for each I/O event, bundle this information into the handshake call itself and track whether handshake is in progress in the caller. Signed-off-by: Balazs Scheidler <[email protected]> Signed-off-by: Hofi <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]> Signed-off-by: Hofi <[email protected]>
HofiOne
force-pushed
the
logproto-remove-handshake-in-progress
branch
from
6d7be36 to
d8399c0
Compare
|
Build FAILURE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This itself simplifies the LogProto handshake API
This one is based on #155 by @bazsi but causes a regression.
#407 must be integrated as well, but also must be adjusted to our latest
wildcard-file()source current changesSigned-off-by: Hofi [email protected]