Skip to content

Commit

Permalink
Remove the redundant code
Browse files Browse the repository at this point in the history
proc_remove does nothing when the argument is NULL[1]. We don't need
proc_remove after proc_create failed.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/proc/generic.c#n789
  • Loading branch information
NOVBobLee committed Oct 6, 2024
1 parent 3a09a1e commit 8c641a2
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion examples/procfs1.c
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ static int __init procfs1_init(void)
{
our_proc_file = proc_create(procfs_name, 0644, NULL, &proc_file_fops);
if (NULL == our_proc_file) {
proc_remove(our_proc_file);
pr_alert("Error:Could not initialize /proc/%s\n", procfs_name);
return -ENOMEM;
}
Expand Down

0 comments on commit 8c641a2

Please sign in to comment.