Fix build failures and expand test coverage #535

eleanorLYJ · 2025-01-06T16:58:32Z

Fix build issues and enhance build system tests

Improve our build system testing and fix various build issues discovered in the process

CI Improvements

Add compiler matrix to test with both gcc-latest and clang-latest
Set warnings as errors to catch potential issues early
Add diverse build configurations testing

Build Fixes

Fix linker error when using Clang by adding missing $(LDFLAGS)
Resolve multiple compiler warning, including:
- Enabling JIT with specific features disabled, such as Zba, Zbb, Zbc, Zbs, EXT_M, or Zicsr
- Disabling Zicsr
- Disabling MOP_FUSIO
Resolve multiple Clang-specific build errors, including:
- Enabling JIT when EXT_M or EXT_C disabled
- Disabling BLOCK_CHAINING
- Disabling MOP FUSION
- Disabling Zicsr

Testing Done

Test builds with various feature flags disabled
Confirm CI pipeline runs successfully with all new test cases

jserv

Benchmarks

Benchmark suite	Current: `99c52b9`	Previous: `3f37f51`	Ratio
`Dhrystone`	`1327` Average DMIPS over 10 runs	`1317` Average DMIPS over 10 runs	`0.99`
`Coremark`	`954.362` Average iterations/sec over 10 runs	`956.978` Average iterations/sec over 10 runs	`1.00`

This comment was automatically generated by workflow using github-action-benchmark.

visitorckw · 2025-01-06T17:10:07Z

.github/workflows/main.yml

+            make ENABLE_JIT=1 clean && make ENABLE_Zba=0 ENABLE_JIT=1 check -j$(nproc)
+            make ENABLE_JIT=1 clean && make ENABLE_Zbb=0 ENABLE_JIT=1 check -j$(nproc)
+            make ENABLE_JIT=1 clean && make ENABLE_Zbc=0 ENABLE_JIT=1 check -j$(nproc)
+            make ENABLE_JIT=1 clean && make ENABLE_Zbs=0 ENABLE_JIT=1 check -j$(nproc)


How about repeating all diverse configuration tests with JIT enabled?

visitorckw · 2025-01-06T17:10:20Z

.github/workflows/main.yml

+            make distclean && make ENABLE_Zba=0 check -j$(nproc)
+            make distclean && make ENABLE_Zbb=0 check -j$(nproc)
+            make distclean && make ENABLE_Zbc=0 check -j$(nproc)
+            make distclean && make ENABLE_Zbs=0 check -j$(nproc)


Maybe also add:
make distclean && make ENABLE_Zifencei=0 check -j$(nproc)

visitorckw · 2025-01-06T17:14:38Z

Hmmm, it seems CI fails due to insufficient memory. Any ideas on how we can reduce the memory usage?

henrybear327 · 2025-01-07T20:25:06Z

Makefile

@@ -7,7 +7,7 @@ BIN := $(OUT)/rv32emu
 CONFIG_FILE := $(OUT)/.config
 -include $(CONFIG_FILE)

-CFLAGS = -std=gnu99 -O2 -Wall -Wextra


Since we are modifying this, do we also want to add -Wshadow to catch more problems :) ?

I think this depends on whether our coding style aims to forbid local variables from shadowing other variables?

.github/workflows/main.yml

visitorckw · 2025-01-10T17:24:38Z

Hmmm, it seems CI fails due to insufficient memory. Any ideas on how we can reduce the memory usage?

Sorry for the misleading description. The CI failure is due to the addition of more tests, causing excessive http requests to github.com during the fetch-checksum, which results in a 403 too many requests error. Here’s the error log:

--2025-01-10 17:19:46--  https://api.github.com/repos/sysprog21/rv32emu-prebuilt/releases
Resolving api.github.com (api.github.com)... 140.82.114.6
Connecting to api.github.com (api.github.com)|140.82.114.6|:443... connected.
HTTP request sent, awaiting response... 403 rate limit exceeded
2025-01-10 17:19:46 ERROR 403: rate limit exceeded.

eleanorLYJ · 2025-01-11T15:43:45Z

Sorry for the misleading description. The CI failure is due to the addition of more tests, causing excessive http requests to github.com during the fetch-checksum, which results in a 403 too many requests error. Here’s the error log:
--2025-01-10 17:19:46--  https://api.github.com/repos/sysprog21/rv32emu-prebuilt/releases
Resolving api.github.com (api.github.com)... 140.82.114.6
Connecting to api.github.com (api.github.com)|140.82.114.6|:443... connected.
HTTP request sent, awaiting response... 403 rate limit exceeded
2025-01-10 17:19:46 ERROR 403: rate limit exceeded.

I noticed that we make frequent requests to fetch the checksum file and store it in $(BIN_DIR)/sha1sum-linux-image.

To reduce the number of requests, we could modify the code to check if the checksum file already exists and is less than a day old. If it’s up-to-date, we can skip fetching it again. This way, we minimize unnecessary requests.

Any thoughts?

jserv · 2025-01-11T16:31:02Z

I noticed that we make frequent requests to fetch the checksum file and store it in $(BIN_DIR)/sha1sum-linux-image.

To reduce the number of requests, we could modify the code to check if the checksum file already exists and is less than a day old. If it’s up-to-date, we can skip fetching it again. This way, we minimize unnecessary requests.

Yes, create an issue for tracking.
Cc. @vacantron

Add the -Werror flag to the CFLAGS to treat all warnings as errors during the build process. This ensures that warnings are blocked by CI, enforcing cleaner code and preventing builds from succeeding with any warnings

When using make 'ENABLE_JIT=1', the following error is observed: src/jit.c:1760:17: error: ‘do_sret’ defined but not used [-Werror=unused-function] 1760 | static void do_##inst(struct jit_state *state UNUSED, riscv_t *rv UNUSED, \ | ^~~ Add "SYSTEM" to the EXT_LIST, which cause SERT to be add SKIP_LIST during template generation. The prevents the generatoin of unused JIT code for the SERT instruction. Fixes: fc0d878 ("Preliminary support for trap handling during block emulation")

ChinYikMing · 2025-01-14T05:38:24Z

I'll help review the pull request this week. Thanks.

visitorckw

Except for the occasional rate limit exceed issue when fetching checksums in CI, everything else LGTM!

I'm surprised there are so many compilation issues. Thanks for your work!

Add compiler matrix strategy to test builds with both gcc and clang compilers. This ensures the codebase compiles and passes tests with different compilers.

When using 'make ENABLE_Zba=0 ENABLE_JIT=1', the following errors are observed: src/jit.c:1760:17: error: ‘do_sh3add’ defined but not used [-Werror=unused-function] src/jit.c:1760:17: error: ‘do_sh2add’ defined but not used [-Werror=unused-function] src/jit.c:1760:17: error: ‘do_sh1add’ defined but not used [-Werror=unused-function] Include 'Zba' in EXT_LIST to ensure instructions like 'sh3add', 'sh2add', and 'sh1add' are properly handled, resolving unused function errors during JIT builds.

Add a new test case to the CI pipeline to verify JIT functionality when the Zba extension is disabled. This ensures better coverage and prevents regressions for this specific configuration.

When using 'make ENABLE_Zbb=0 ENABLE_JIT=1', the following errors are observed: src/jit.c:1760:17: error: ‘do_rev8’ defined but not used [-Werror=unused-function] src/jit.c:1760:17: error: ‘do_orcb’ defined but not used [-Werror=unused-function] src/jit.c:1760:17: error: ‘do_rori’ defined but not used [-Werror=unused-function] src/jit.c:1760:17: error: ‘do_ror’ defined but not used [-Werror=unused-function] src/jit.c:1760:17: error: ‘do_rol’ defined but not used [-Werror=unused-function] src/jit.c:1760:17: error: ‘do_zexth’ defined but not used [-Werror=unused-function] src/jit.c:1760:17: error: ‘do_sexth’ defined but not used [-Werror=unused-function] src/jit.c:1760:17: error: ‘do_sextb’ defined but not used [-Werror=unused-function] src/jit.c:1760:17: error: ‘do_minu’ defined but not used [-Werror=unused-function] src/jit.c:1760:17: error: ‘do_maxu’ defined but not used [-Werror=unused-function] src/jit.c:1760:17: error: ‘do_min’ defined but not used [-Werror=unused-function] src/jit.c:1760:17: error: ‘do_max’ defined but not used [-Werror=unused-function] src/jit.c:1760:17: error: ‘do_cpop’ defined but not used [-Werror=unused-function] src/jit.c:1760:17: error: ‘do_ctz’ defined but not used [-Werror=unused-function] src/jit.c:1760:17: error: ‘do_clz’ defined but not used [-Werror=unused-function] src/jit.c:1760:17: error: ‘do_xnor’ defined but not used [-Werror=unused-function] src/jit.c:1760:17: error: ‘do_orn’ defined but not used [-Werror=unused-function] src/jit.c:1760:17: error: ‘do_andn’ defined but not used [-Werror=unused-function] Include 'Zbb' in EXT_LIST to ensure instructions like 'rev8', 'orcb', and 'rori' are properly handled, resolving unused function errors during JIT builds.

Add a new test case to the CI pipeline to verify JIT functionality when the Zbb extension is disabled. This ensures better coverage and prevents regressions for this specific configuration.

When using 'make ENABLE_Zbc=0 ENABLE_JIT=1', the following errors are observed: src/jit.c:1760:17: error: ‘do_clmulr’ defined but not used [-Werror=unused-function] src/jit.c:1760:17: error: ‘do_clmulh’ defined but not used [-Werror=unused-function] src/jit.c:1760:17: error: ‘do_clmul’ defined but not used [-Werror=unused-function] Include 'Zbc' in EXT_LIST to ensure instructions like 'clmulr', 'clmulh', and 'clmul' are properly handled, resolving unused function errors during JIT builds.

Add a new test case to the CI pipeline when the Zbc is disabled. This ensures better coverage and prevents regressions for this specific configuration.

Add a new test case to the CI pipeline when the Zbs is disabled. This ensures better coverage and prevents regressions for this specific configuration.

ChinYikMing · 2025-01-15T19:55:50Z

src/emulate.c

@@ -688,6 +708,7 @@ static void block_translate(riscv_t *rv, block_t *block)
        remove_next_nth_ir(rv, ir, block, count - 1);             \
    }

+#if RV32_HAS(MOP_FUSION)


Move this to line 686, as COMBINE_MEM_OPS macro is only utilized when MOP_FUSION is enabled and for readability, such that:

#if RV32_HAS(MOP_FUSION) #define COMBINE_MEM_OPS(RW) ...

ChinYikMing · 2025-01-15T19:56:40Z

src/emulate.c

@@ -702,7 +723,9 @@ static inline void remove_next_nth_ir(const riscv_t *rv,
        block->ir_tail = ir;
    block->n_insn -= n;
 }
+#endif


Remove this since line 826 cover the condition.

ChinYikMing · 2025-01-15T19:57:18Z

src/emulate.c


+#if RV32_HAS(MOP_FUSION)


Remove this since line 686 cover this.

Thank you for your comment.
I noticed that line 686 isn’t protected by the macro (if RV32_HAS(MOP_FUSION)). Perhaps you mean the code starting from line 711 is protected?

Thank you for your comment. I noticed that line 686 isn’t protected by the macro (if RV32_HAS(MOP_FUSION)). Perhaps you mean the code starting from line 711 is protected?

Check this:

#if RV32_HAS(MOP_FUSION) #define COMBINE_MEM_OPS(RW) ...

You're right. The macro should start covering from line 686 instead, as 'remove_next_nth_ir' is used inside the '#define COMBINE_MEM_OPS(RW)'.

ChinYikMing · 2025-01-15T20:02:26Z

src/emulate.c

 static uint64_t ctr = 0;
 static inline void update_time(riscv_t *rv)
 {
    rv->csr_time[0] = ctr & 0xFFFFFFFF;
    rv->csr_time[1] = ctr >> 32;
 }
+#endif


Remove this since line 84 covers the condition.

ChinYikMing · 2025-01-15T20:02:32Z

src/emulate.c

 static uint64_t ctr = 0;
 static inline void update_time(riscv_t *rv)
 {
    rv->csr_time[0] = ctr & 0xFFFFFFFF;
    rv->csr_time[1] = ctr >> 32;
 }
+#endif

 #if RV32_HAS(Zicsr)


ChinYikMing · 2025-01-15T20:11:25Z

May I know if the remaining tests will still be executed in case any single test fails?

eleanorLYJ · 2025-01-16T02:58:55Z

May I know if the remaining tests will still be executed in case any single test fails?

Based on the current configuration, if any single test fails, the remaining tests will not be executed. Should we consider allowing the other tests to continue running even if one test fails?

When using 'make ENABLE_Zicsr=0 CC=clang', the following error is observed: src/emulate.c:83:20: error: unused function 'update_time' [-Werror,-Wunused-function] 83 | static inline void update_time(riscv_t *rv) | ^~~~~~~~~~~ 1 error generated Fix this by guarding the update_time function definition with RV32_HAS(Zicsr) macro. This ensures the function is only defined when the Zicsr is enabled.

ChinYikMing · 2025-01-16T03:22:55Z

May I know if the remaining tests will still be executed in case any single test fails?

Based on the current configuration, if any single test fails, the remaining tests will not be executed. Should we consider allowing the other tests to continue running even if one test fails?

Yes, I think revealing all errors or warnings at once for each build flag is a better approach. Moreover, the validation process for both compilers only takes around 3 to 5 minutes based on previous actions log.

When using 'make ENABLE_MOP_FUSION=0 CC=clang', the following error is observed: src/emulate.c:695:20: error: unused function 'remove_next_nth_ir' [-Werror,-Wunused-function] 695 | static inline void remove_next_nth_ir(const riscv_t *rv, | ^~~~~~~~~~~~~~~~~~ 1 error generated. Fix by gurading the 'remove_next_nth_ir' function and the 'COMBINE_MEM_OPS' macro with the 'RV32_HAS(MOP_FUSION)' macro. This ensures both are only included when MOP FUSION is enabled, preventing the Clang warning and maintaining proper functionality.

When using 'make ENABLE_MBLOCK_CHAINING=0 CC=clang', the following errors are observed: src/emulate.c:555:19: error: unused function 'insn_is_unconditional_branch' [-Werror,-Wunused-function] 555 | FORCE_INLINE bool insn_is_unconditional_branch(uint8_t opcode) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/emulate.c:582:19: error: unused function 'insn_is_direct_branch' [-Werror,-Wunused-function] 582 | FORCE_INLINE bool insn_is_direct_branch(uint8_t opcode) | ^~~~~~~~~~~~~~~~~~~~~ Fix this by guarding the 'insn_is_unconditional_branch' and 'insn_is_direct_branch' function definition with RV32_HAS(BLOCK_CHAINING) macro. This ensures the functions are only defined when the BLOCK_CHAINING is enabled.

When using 'make make ENABLE_EXT_C=0 ENABLE_JIT=1 CC=clang', the following errors are observed: rc/t2c.c:77:1: error: unused function 't2c_gen_ra_addr' [-Werror,-Wunused-function] 77 | T2C_LLVM_GEN_ADDR(ra, X, rv_reg_ra); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/t2c.c:64:31: note: expanded from macro 'T2C_LLVM_GEN_ADDR' 64 | FORCE_INLINE LLVMValueRef t2c_gen_##reg##_addr( \ | ^~~~~~~~~~~~~~~~~~~~ <scratch space>:75:1: note: expanded from here 75 | t2c_gen_ra_addr | ^~~~~~~~~~~~~~~ src/t2c.c:78:1: error: unused function 't2c_gen_sp_addr' [-Werror,-Wunused-function] 78 | T2C_LLVM_GEN_ADDR(sp, X, rv_reg_sp); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/t2c.c:64:31: note: expanded from macro 'T2C_LLVM_GEN_ADDR' 64 | FORCE_INLINE LLVMValueRef t2c_gen_##reg##_addr( \ | ^~~~~~~~~~~~~~~~~~~~ Fix this by guarding the 't2c_gen_ra_addr' and 't2c_gen_sp_addr' function definition with RV32_HAS(EXT_C) macro. This ensures the functions are only defined when the EXT_C is enabled.

When using 'make ENABLE_EXT_M=0 ENABLE_JIT=1 CC=clang', the following error is observed: src/jit.c:728:20: error: unused function 'emit_alu64_imm8' [-Werror,-Wunused-function] 728 | static inline void emit_alu64_imm8(struct jit_state *state, | ^~~~~~~~~~~~~~~ Fix this by guarding the 'emit_alu64_imm8' function definition with RV32_HAS(EXT_M) macro. This ensures the function is only defined when the EXT_M is enabled.

When using 'make ENABLE_UBSAN=1 check CC=clang', the following error is observed: src/emulate.c:1110:13: runtime error: call to function do_fuse1 through pointer to incorrect function type 'bool (*)(struct riscv_internal *, const struct rv_insn *, unsigned long, unsigned int)' /home/eleanor/code/rv32emu/src/emulate.c:415: note: do_fuse1 defined here SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior src/emulate.c:1110:13 After fixing the first error with 'do_fuse1', similar errors were observed for other functions like 'do_fuse2', 'do_fuse3', 'do_fuse4', and 'do_jal'. The root cause was type mismatches in parameter declarations, where 'rv_insn_t *' was used instead of the expected 'const rv_insn_t *'. Since 'do_jal' was generated by the 'RVOP' macro in 'rv32emu_template.c', the macro was also corrected. These changes resolve the UBSAN errors and align all function pointers and implementations.

When building with make 'ENABLE_JIT=1 ENABLE_SYSTEM=1', the following error is observed: src/emulate.c:45:13: error: ‘need_clear_block_map’ defined but not used [-Werror=unused-variable] 45 | static bool need_clear_block_map = false; | ^~~~~~~~~~~~~~~~~~~~ Fix this by guarding the 'need_clear_block_map' definition with the RV32_HAS(SYSTEM) and !RV32_HAS(JIT) macros. This ensures the variable is only defined when the macros indicate it is needed.

Building with 'ENABLE_JIT=1, ENABLE_SYSTEM=1, and ENABLE_ELF_LOADER=0' causes the following errors: src/riscv.c:582:18: error: use of undeclared identifier 'attr' 582 | u8250_delete(attr->uart); | ^ src/riscv.c:583:17: error: use of undeclared identifier 'attr' 583 | plic_delete(attr->plic); | ^ These errors occur because attr is not defined under these conditions. Fix this by adjusting the guard for attr to (RV32_HAS(SYSTEM) && !RV32_HAS(ELF_LOADER)), ensuring it is defined as needed.

Add a new test case to the CI pipeline when the Zifencei is disabled. This ensures better coverage and prevents regressions for this specific configuration.

Add a new test case to the CI pipeline to verify JIT functionality when the Zicsr extension is disabled. This ensures better coverage and prevents regressions for this specific configuration.

Add a new test case to the CI pipeline to verify JIT functionality when the Zifencei extension is disabled. This ensures better coverage and prevents regressions for this specific configuration.

Add a new test case to the CI pipeline to verify JIT functionality when the MOP_FUSION extension is disabled. This ensures better coverage and prevents regressions for this specific configuration.

Add a new test case to the CI pipeline to verify JIT functionality when the BLOCK_CHAINING extension is disabled. This ensures better coverage and prevents regressions for this specific configuration.

ChinYikMing · 2025-01-16T04:13:55Z

In 'mk/toolchain.mk', we have emcc (Emscripten). @eleanorLYJ Can you also add the emcc to the CI? The reason is that 'deploy-wasm.yml' is only executed when specific files are changed or manually triggered. By detecting warnings or errors early, we can address them before the actual execution of 'deploy-wasm.yml'.

Ensure that subsequent steps are executed regardless of the success or failure of previous steps while providing more explicit control over step execution.

eleanorLYJ · 2025-01-16T15:12:29Z

In 'mk/toolchain.mk', we have emcc (Emscripten). @eleanorLYJ Can you also add the emcc to the CI? The reason is that 'deploy-wasm.yml' is only executed when specific files are changed or manually triggered. By detecting warnings or errors early, we can address them before the actual execution of 'deploy-wasm.yml'.

The current action we are using, rlalik/setup-cpp-compiler, does not support installing emcc at the moment. I plan to address this limitation in the next PR by implementing functionality to include emcc in the CI setup.

ChinYikMing · 2025-01-17T02:56:08Z

In 'mk/toolchain.mk', we have emcc (Emscripten). @eleanorLYJ Can you also add the emcc to the CI? The reason is that 'deploy-wasm.yml' is only executed when specific files are changed or manually triggered. By detecting warnings or errors early, we can address them before the actual execution of 'deploy-wasm.yml'.

The current action we are using, rlalik/setup-cpp-compiler, does not support installing emcc at the moment. I plan to address this limitation in the next PR by implementing functionality to include emcc in the CI setup.

Got it. Looking forward to that!

ChinYikMing

LGTM.

jserv · 2025-01-17T03:18:45Z

Thank @eleanorLYJ for contributing!

Fix build failures and expand test coverage

jserv requested review from ChinYikMing, vacantron and visitorckw January 6, 2025 17:00

jserv reviewed Jan 6, 2025

View reviewed changes

visitorckw reviewed Jan 6, 2025

View reviewed changes

jserv requested a review from henrybear327 January 6, 2025 17:17

eleanorLYJ force-pushed the improve-build-tests branch 2 times, most recently from ba5521c to 08146d9 Compare January 7, 2025 07:54

eleanorLYJ changed the title ~~Fix Build Issues and Enhance Build System Tests~~ Fix build issues and enhance build system tests Jan 7, 2025

henrybear327 reviewed Jan 7, 2025

View reviewed changes

henrybear327 mentioned this pull request Jan 7, 2025

Integrate deterministic memory pool #94

Open

jserv changed the title ~~Fix build issues and enhance build system tests~~ Fix build failures and expand test coverage Jan 8, 2025

jserv reviewed Jan 8, 2025

View reviewed changes

.github/workflows/main.yml Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

jserv added this to the release-2025.1 milestone Jan 12, 2025

eleanorLYJ added 2 commits January 13, 2025 13:11

Treat warnings as errors by adding -Werror

75d3725

Add the -Werror flag to the CFLAGS to treat all warnings as errors during the build process. This ensures that warnings are blocked by CI, enforcing cleaner code and preventing builds from succeeding with any warnings

eleanorLYJ force-pushed the improve-build-tests branch from 08146d9 to 89a7356 Compare January 13, 2025 13:25

visitorckw approved these changes Jan 15, 2025

View reviewed changes

eleanorLYJ added 6 commits January 16, 2025 00:00

CI: Add compiler matrix for gcc and clang testing

9747560

Add compiler matrix strategy to test builds with both gcc and clang compilers. This ensures the codebase compiles and passes tests with different compilers.

CI: Add test case for disabling Zba with JIT enabled

30eca0e

Add a new test case to the CI pipeline to verify JIT functionality when the Zba extension is disabled. This ensures better coverage and prevents regressions for this specific configuration.

CI: Add test case for disabling Zbb with JIT enabled

3aa33ec

Add a new test case to the CI pipeline to verify JIT functionality when the Zbb extension is disabled. This ensures better coverage and prevents regressions for this specific configuration.

eleanorLYJ added 2 commits January 16, 2025 00:01

CI: Add test case for disabling Zbc

6d2ca02

Add a new test case to the CI pipeline when the Zbc is disabled. This ensures better coverage and prevents regressions for this specific configuration.

CI: Add test case for disabling Zbs

7384d92

Add a new test case to the CI pipeline when the Zbs is disabled. This ensures better coverage and prevents regressions for this specific configuration.

eleanorLYJ force-pushed the improve-build-tests branch from 89a7356 to d302919 Compare January 15, 2025 16:02

ChinYikMing reviewed Jan 15, 2025

View reviewed changes

eleanorLYJ added 12 commits January 16, 2025 11:33

CI: Add test case for disabling Zifencei

1bb3cdf

Add a new test case to the CI pipeline when the Zifencei is disabled. This ensures better coverage and prevents regressions for this specific configuration.

CI: Add test case for disabling Zicsr with JIT enabled

eb9ea7b

Add a new test case to the CI pipeline to verify JIT functionality when the Zicsr extension is disabled. This ensures better coverage and prevents regressions for this specific configuration.

CI: Add test case for disabling Zifencei with JIT enabled

61176c0

Add a new test case to the CI pipeline to verify JIT functionality when the Zifencei extension is disabled. This ensures better coverage and prevents regressions for this specific configuration.

CI: Add test case for disabling MOP_FUSION with JIT enabled

004180a

Add a new test case to the CI pipeline to verify JIT functionality when the MOP_FUSION extension is disabled. This ensures better coverage and prevents regressions for this specific configuration.

CI: Add test case for disabling BLOCK_CHAINING with JIT enabled

be10551

Add a new test case to the CI pipeline to verify JIT functionality when the BLOCK_CHAINING extension is disabled. This ensures better coverage and prevents regressions for this specific configuration.

eleanorLYJ force-pushed the improve-build-tests branch from d302919 to 3f37f51 Compare January 16, 2025 14:59

CI: Add 'if: always()' for steps

99c52b9

Ensure that subsequent steps are executed regardless of the success or failure of previous steps while providing more explicit control over step execution.

eleanorLYJ force-pushed the improve-build-tests branch from 3f37f51 to 99c52b9 Compare January 16, 2025 15:06

ChinYikMing approved these changes Jan 17, 2025

View reviewed changes

jserv merged commit e2993fc into sysprog21:master Jan 17, 2025
9 checks passed

vestata pushed a commit to vestata/rv32emu that referenced this pull request Jan 24, 2025

Merge pull request sysprog21#535 from eleanorLYJ/improve-build-tests

d280450

Fix build failures and expand test coverage

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix build failures and expand test coverage #535

Fix build failures and expand test coverage #535

eleanorLYJ commented Jan 6, 2025 •

edited

Loading

jserv left a comment •

edited

Loading

visitorckw Jan 6, 2025

visitorckw Jan 6, 2025

visitorckw commented Jan 6, 2025

henrybear327 Jan 7, 2025

visitorckw Jan 8, 2025

visitorckw commented Jan 10, 2025

This comment was marked as outdated.

eleanorLYJ commented Jan 11, 2025 •

edited

Loading

jserv commented Jan 11, 2025

ChinYikMing commented Jan 14, 2025

visitorckw left a comment

ChinYikMing Jan 15, 2025 •

edited

Loading

ChinYikMing Jan 15, 2025

eleanorLYJ Jan 16, 2025

ChinYikMing Jan 15, 2025

eleanorLYJ Jan 16, 2025 •

edited

Loading

ChinYikMing Jan 16, 2025

eleanorLYJ Jan 16, 2025

ChinYikMing Jan 15, 2025

eleanorLYJ Jan 16, 2025

ChinYikMing Jan 15, 2025

eleanorLYJ Jan 16, 2025

ChinYikMing commented Jan 15, 2025

eleanorLYJ commented Jan 16, 2025

ChinYikMing commented Jan 16, 2025

ChinYikMing commented Jan 16, 2025 •

edited

Loading

eleanorLYJ commented Jan 16, 2025

ChinYikMing commented Jan 17, 2025

ChinYikMing left a comment

jserv commented Jan 17, 2025

Fix build failures and expand test coverage #535

Fix build failures and expand test coverage #535

Conversation

eleanorLYJ commented Jan 6, 2025 • edited Loading

Fix build issues and enhance build system tests

CI Improvements

Build Fixes

Testing Done

jserv left a comment • edited Loading

Choose a reason for hiding this comment

Benchmarks

Choose a reason for hiding this comment

Choose a reason for hiding this comment

visitorckw commented Jan 6, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

visitorckw commented Jan 10, 2025

This comment was marked as outdated.

eleanorLYJ commented Jan 11, 2025 • edited Loading

jserv commented Jan 11, 2025

ChinYikMing commented Jan 14, 2025

visitorckw left a comment

Choose a reason for hiding this comment

ChinYikMing Jan 15, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eleanorLYJ Jan 16, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChinYikMing commented Jan 15, 2025

eleanorLYJ commented Jan 16, 2025

ChinYikMing commented Jan 16, 2025

ChinYikMing commented Jan 16, 2025 • edited Loading

eleanorLYJ commented Jan 16, 2025

ChinYikMing commented Jan 17, 2025

ChinYikMing left a comment

Choose a reason for hiding this comment

jserv commented Jan 17, 2025

eleanorLYJ commented Jan 6, 2025 •

edited

Loading

jserv left a comment •

edited

Loading

eleanorLYJ commented Jan 11, 2025 •

edited

Loading

ChinYikMing Jan 15, 2025 •

edited

Loading

eleanorLYJ Jan 16, 2025 •

edited

Loading

ChinYikMing commented Jan 16, 2025 •

edited

Loading