Implement parser for #include preprocessor directive
#110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ChAoSUnItY
force-pushed
the
front-end-separate
branch
from
b000340 to
03053e5
Compare
ChAoSUnItY
changed the title
#include preprocessor directive & constant evaluation for #if and #elif
|
Can you decouple "Implement parser for #include preprocessor directive & constant evaluation for #if and #elif" into two pull requests? So that, it is more straightforward for reviewing. |
vacantron
reviewed
Feb 22, 2024
ChAoSUnItY
force-pushed
the
front-end-separate
branch
from
03053e5 to
8fc51b0
Compare
ChAoSUnItY
changed the title
#include preprocessor directive & constant evaluation for #if and #elif#include preprocessor directive
jserv
requested changes
Feb 23, 2024
ChAoSUnItY
force-pushed
the
front-end-separate
branch
from
8fc51b0 to
13418b5
Compare
jserv
requested changes
Feb 23, 2024
There was a problem hiding this comment.
- Don't indent git commit messages. For example, instead of writing "- This syntax parser can parse 2 forms," simply write "This syntax parser can parse 2 forms." without the leading
-. - Avoid using backticks in git commit messages. Instead, use (double) quotation marks. This approach ensures compatibility with most editors.
This syntax parser can parse 2 forms of #include, including '#include "header.h"' (string path form) and '#include <header.h>' (system defined path form), the former one is guaranteed to be always parsed, however, the later one is not guaranteed will be always successfully parsed due to lack of platform support.
ChAoSUnItY
force-pushed
the
front-end-separate
branch
from
13418b5 to
001ab29
Compare
|
Thank @ChAoSUnItY for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#includepreprocessor directive to avoid potential syntax error.