Implement multiplication for RV32I #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
changed the title
jserv
reviewed
Jun 18, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
This pull request just resolves implementing multiplication for RV32I, but division is still dependent on RV32M. |
jserv
requested changes
Jun 19, 2024
This commit allows shecc to generate a sequence of instructions to perform multiplication for RISC-V targets with RV32I only.
|
I apologize for using improper git commit messages. I will refine my messages and update it. |
|
Thank @DrXiao for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, shecc would just generate hardware multiplication instructions for multiplication operations.
This commit adjusts
riscv-codegen.cso that shecc can generate a sequence of instructions to achieve multiplication without any RV32M instruction if the '+m' option is disable.Related: #46