Fix Arm outputs for right shift operations #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let shecc generate arithmetic shift right instructions for right shift operations instead of using logical shift right instructions. Currently, the behavior of right shift operations is consistent with GCC and Clang.
vacantron
approved these changes
Aug 3, 2024
|
Thank @DrXiao for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the discussion in the pull request (#126) mentioned, shecc generates logical right shift instructions for right shift operations on Arm targets currently. However, the most famous compilers such as GCC or Clang generate arithmetic right shift instructions for the operations.
Therefore, this pull request modifies the Arm backend so that the behavior of right shift operations is consistent with GCC and Clang.