Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Profobuf messages #1

Merged
merged 2 commits into from
Aug 28, 2020
Merged

Conversation

doomspork
Copy link
Contributor

A starting point for our conversation on leveraging Protobuf messages in our events.

@doomspork
Copy link
Contributor Author

In the interest of not going hogwild with CI/CD — yet — we're going to need to manually generate the Elixir files when updating the Protobuf files.

@doomspork
Copy link
Contributor Author

We should also discuss whether or not we want to wrap all of our messages in an "Envelope" that contains meta data we might want (timestamps, source, et al).

@btkostner
Copy link
Contributor

mhmmm, we should at least create a mix task / alias to run that command. Are we able to override the built in mix compile command to also run that command or would that be horrible / impossible?

@btkostner
Copy link
Contributor

Also, if we are generating elixir in this repo, why not just have elixir code without the protobuf stuff? If we are planning to use this across languages, we should make this repo just the protobuf stuff and do all of the elixir stuff in what ever project uses this.

mix.exs Outdated

defp aliases do
[
"protobuf.gen": ["protoc --elixir_out=./lib/bottle -I priv/protos/ priv/protos/*.proto
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:parrotwave1: :parrotwave2: :parrotwave3: :parrotwave4: :parrotwave5: :parrotwave6: :parrotwave7: :parrotwave8: :parrotwave9:

@doomspork doomspork force-pushed the scallan-add-order-related-messages branch from f2cd347 to a544a66 Compare August 28, 2020 18:27
.formatter.exs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@doomspork doomspork force-pushed the scallan-add-order-related-messages branch from a544a66 to e512b93 Compare August 28, 2020 18:31
@doomspork doomspork changed the title Add Order messages Initial Profobuf messages Aug 28, 2020
Co-authored-by: Blake Kostner <[email protected]>
@btkostner btkostner merged commit 2a9b695 into master Aug 28, 2020
@btkostner btkostner deleted the scallan-add-order-related-messages branch August 28, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants