-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Profobuf messages #1
Conversation
In the interest of not going hogwild with CI/CD — yet — we're going to need to manually generate the Elixir files when updating the Protobuf files. |
We should also discuss whether or not we want to wrap all of our messages in an "Envelope" that contains meta data we might want (timestamps, source, et al). |
mhmmm, we should at least create a mix task / alias to run that command. Are we able to override the built in |
Also, if we are generating elixir in this repo, why not just have elixir code without the protobuf stuff? If we are planning to use this across languages, we should make this repo just the protobuf stuff and do all of the elixir stuff in what ever project uses this. |
mix.exs
Outdated
|
||
defp aliases do | ||
[ | ||
"protobuf.gen": ["protoc --elixir_out=./lib/bottle -I priv/protos/ priv/protos/*.proto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f2cd347
to
a544a66
Compare
a544a66
to
e512b93
Compare
Co-authored-by: Blake Kostner <[email protected]>
A starting point for our conversation on leveraging Protobuf messages in our events.