Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource ID should be type string #10

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Conversation

doomspork
Copy link
Contributor

As we move more into event based architecture we'll need to leverage UUIDs more and more for our PKs. Setting all the IDs to string now is a good way to get us ready for that. This one was missed before.

@doomspork
Copy link
Contributor Author

Since we aren't using this yet I'm okay with the breaking change. This should have been made in the first place. It not existing is breaking the code 🎉

@doomspork doomspork merged commit 474d26a into master Sep 10, 2020
@doomspork doomspork deleted the scallan-fix-order-id-type branch September 10, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants