Wrap resources with timestamp and id #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doomspork
commented
Sep 28, 2020
protos/bottle/core/v1/case.proto
Outdated
| string requestId = 2; | ||
| string source = 3; | ||
|
|
||
| oneof bottle { |
There was a problem hiding this comment.
Later we can use Case to wrap up other resources but for now the only "top level" one we have is an Order.
There was a problem hiding this comment.
Should we just call this something like resource?
There was a problem hiding this comment.
resource seems good and generic. Why is this named Case? Can we do something like Message?
doomspork
force-pushed
the
scallan-add-tracing-fields
branch
from
d215a7e to
6892a6e
Compare
doomspork
force-pushed
the
scallan-add-tracing-fields
branch
from
edd3329 to
6892a6e
Compare
btkostner
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to allow us to pass along the
requestIdfrom the web layer so we can trace requests. We also include asourceand atimestampfor good record keeping.