Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add order payment type #12

Merged
merged 3 commits into from
Oct 12, 2020
Merged

Add order payment type #12

merged 3 commits into from
Oct 12, 2020

Conversation

doomspork
Copy link
Contributor

No description provided.

import "bottle/account/v1/user.proto";
import "bottle/catalog/v1/product.proto";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔤 sorting.

@@ -13,6 +13,7 @@ message Order {
bottle.account.v1.Address shipping = 3;
bottle.account.v1.Address billing = 4;
string shipping_method = 5;

string payment_method = 7;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stripe, check, wire_transfer, et al.

Copy link
Contributor

@btkostner btkostner Oct 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to change this from string to enum

@doomspork doomspork requested a review from a team October 12, 2020 17:09
@doomspork doomspork force-pushed the scallan-add-payment-method branch from 7edd5cd to f89a172 Compare October 12, 2020 17:23
@btkostner btkostner merged commit c897a15 into master Oct 12, 2020
@btkostner btkostner deleted the scallan-add-payment-method branch October 12, 2020 17:29
@doomspork
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants