The beginning of notifications #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btkostner
approved these changes
Oct 27, 2020
doomspork
force-pushed
the
scallan-notifications
branch
from
341aa11 to
3f6056a
Compare
doomspork
force-pushed
the
scallan-notifications
branch
from
2d075ff to
467c9cb
Compare
btkostner
reviewed
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This won't be backwards compatible because I renamed the
Messagetype toBottlebecauseMessageis used by Broadway andmessageis a protobuf keyword but this resource is not in used yet so we should be good to go.I'm going to work on a notification service that will handle these errors for the time being, the first usage will be bubbling Tribble / Joshua order processing error up into Slack for Sam and team.