Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory & Assembly proposal #16

Merged
merged 2 commits into from
Dec 1, 2020
Merged

Conversation

doomspork
Copy link
Contributor

This isn't complete, I'll expand on how these will be used later today 👍

@doomspork doomspork force-pushed the scallan-inventory-assembly branch from a3bf893 to f85d6ea Compare November 12, 2020 16:19
@doomspork doomspork force-pushed the scallan-inventory-assembly branch 2 times, most recently from 2e514ec to 01522c6 Compare December 1, 2020 16:27
@doomspork doomspork marked this pull request as ready for review December 1, 2020 16:28
@doomspork doomspork requested a review from a team as a code owner December 1, 2020 16:28
Copy link
Contributor

@btkostner btkostner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about how the split here is at BuildCreated and not OrderCreated and at first I was against it long term. But thinking about it, long term we would want to split out Fulfillment.Product to be able to keep track of each quantity independently for returns anyway. So this split makes more sense long term than what I was thinking.


package bottle.inventory.events.v1;

message ComponentAvailabilityRequested {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a quantity request and change in queue seems weird to me, but I guess this makes sense with our current infrastructure. I know that aws elb support grpc if we want to start working with that for this project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has felt meh to me as well. My thinking was they don't need to be synchronous so it didn't seem necessary to introduce a mechanism to achieve that when it isn't required.

(We discussed in Slack, we'll use this for now and circle back to this later)

protos/bottle/assembly/v1/build.proto Outdated Show resolved Hide resolved
@doomspork doomspork force-pushed the scallan-inventory-assembly branch from b3abe34 to e62e6c8 Compare December 1, 2020 22:58
@doomspork doomspork force-pushed the scallan-inventory-assembly branch from b3993c3 to 9111ba7 Compare December 1, 2020 23:30
@doomspork doomspork merged commit d6c73fd into master Dec 1, 2020
@doomspork doomspork deleted the scallan-inventory-assembly branch December 1, 2020 23:48
@doomspork
Copy link
Contributor Author

Thanks for the help @btkostner 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants