-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inventory & Assembly proposal #16
Conversation
a3bf893
to
f85d6ea
Compare
2e514ec
to
01522c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about how the split here is at BuildCreated
and not OrderCreated
and at first I was against it long term. But thinking about it, long term we would want to split out Fulfillment.Product
to be able to keep track of each quantity independently for returns anyway. So this split makes more sense long term than what I was thinking.
|
||
package bottle.inventory.events.v1; | ||
|
||
message ComponentAvailabilityRequested { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a quantity request and change in queue seems weird to me, but I guess this makes sense with our current infrastructure. I know that aws elb support grpc if we want to start working with that for this project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has felt meh to me as well. My thinking was they don't need to be synchronous so it didn't seem necessary to introduce a mechanism to achieve that when it isn't required.
(We discussed in Slack, we'll use this for now and circle back to this later)
b3abe34
to
e62e6c8
Compare
b3993c3
to
9111ba7
Compare
Thanks for the help @btkostner 🎉 |
This isn't complete, I'll expand on how these will be used later today 👍