-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update desktop-environment.md #1190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The article shows how to install KDE by running sudo apt install kde-standard
, which will install kde-standard
's dependencies. Running an autoremove --purge kde-standard
will remove kde-standard
and everything installed as a dependency of it. There's no reason why kde-*
would be needed unless the user installed KDE via a different package/method.
The kde-*
wildcard may uninstall more packages than intended; for example, if I installed the kde-spectacle
program to use in GNOME, then I later installed kde-standard
, running sudo apt purge kde-*
will remove kde-spectacle
even though it wasn't installed as part of the desktop environment.
Also, purge
is actually less comprehensive than an autoremove --purge
because purge
will not remove dependencies by itself; it would require another autoremove --purge
after it. (In this case, there is one immediately after it, but specifying kde-standard
in that one after kde-*
was already purged is redundant.) It's probably best to use autoremove --purge
in all instances here.
I think there's a place for the wildcard/pattern-matching concept in this article, but it should be separated into a separate section for if the reader's forgotten which package(s) they manually installed.
Additionally, * wildcards aren't reliable; if you touch kde-testing
and then try to run the sudo apt purge kde-*
command in the same directory, you'll get an error that no kde-testing
package is found, because that wildcard is matched to the filename rather than package names. Instead, sudo apt purge '?name(^kde-)'
would do the same thing (remove packages starting with kde-
), without running into issues in case of matching filenames.
@jacobgkau Thank you for the feedback and explanation. I did not consider those points prior to the PR. I'll run some more tests, if nothing goods come out, I drop the PR. Bye. |
To test the current example and documentation:
The method in this PR was found on Stack Overflow, but I traced it to the old version of these docs. Although the old/proposed method can remove unintended packages, the current method does not remove the necessary packages. |
Thank you for the steps and elaborating on the issue. I can recreate that with (Playing around with If we do stick with the wildcard option, we'll still want to use regex rather than the asterisk. |
Still, the regex would need to be Maybe change the example to another desktop environment, and include a warning about kde remaining packages after install? This way people can choose how to proceed. |
I don't see how removing the KDE example will help if that's one that we know currently has problems.
Actually, using the With |
I've tried to explain the example in a simple but effective way. I do think this is a valuable addition, so thanks for bringing it up. (Let me know if you see any issues with what I changed it to.) |
My bad. I used
Looks good to me. Thank you. |
This addition offers users a more comprehensive solution for removing KDE and its associated packages. This enhancement aims to provide clearer and more user-friendly instructions for managing desktop environments on Pop!_OS.
@memachado is this ready to go with your latest changes? |
@ahoneybun Yes. |
This addition offers users a more comprehensive solution for removing KDE and its associated packages. This enhancement aims to provide clearer and more user-friendly instructions for managing desktop environments on Pop!_OS.