Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the page to be more clear and include Thelio Io v2 #1266

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

ahoneybun
Copy link
Member

This PR does the following:

  • Adds a link to the guide article rather than per model (some pretty old)
  • Adds a photo (and text to make it more clear) for the Thelio Io v2 board

I would want to update the v1 photo from the tech docs but I just see this which mean but less clear.

https://tech-docs.system76.com/models/thelio-b4/img/thelio-io-wiring.webp

@ahoneybun ahoneybun requested review from a team and thomas-zimmerman January 21, 2025 20:22
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The captions under the photos feel a bit awkward, but I think they still get the point across. There are other oddities with this article that are unrelated to this PR though, so I think this could be merged now, and a future PR could be opened to polish it up a bit more.

@thomas-zimmerman
Copy link
Contributor

I like the change and gives us some place to show the different IO boards.

@leviport
Copy link
Member

@thomas-zimmerman if you leave an approving review, you'll be able to merge it

Copy link
Contributor

@thomas-zimmerman thomas-zimmerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR

@thomas-zimmerman thomas-zimmerman merged commit 0af2635 into master Jan 23, 2025
3 checks passed
@thomas-zimmerman thomas-zimmerman deleted the update-power-on-failure branch January 23, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants