-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdf): Add apply/merge_status automation API endpoints #5277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
jkeiser
force-pushed
the
jkeiser/apply-changeset-endpoint
branch
3 times, most recently
from
January 16, 2025 22:10
a59c9e9
to
411cfc8
Compare
jkeiser
changed the title
feat(sdf): Add apply_changeset and request_approval automation API endpoints
feat(sdf): Add request_approval automation API endpoint
Jan 16, 2025
jkeiser
force-pushed
the
jkeiser/apply-changeset-endpoint
branch
from
January 18, 2025 00:04
411cfc8
to
903f5ca
Compare
jkeiser
changed the title
feat(sdf): Add request_approval automation API endpoint
feat(sdf): Add force_apply/request_approval automation API endpoints
Jan 18, 2025
jkeiser
force-pushed
the
jkeiser/apply-changeset-endpoint
branch
from
January 18, 2025 00:15
903f5ca
to
2f2ee47
Compare
Dropping this back to Draft briefly to add another endpoint. May as well round it out! |
jkeiser
force-pushed
the
jkeiser/apply-changeset-endpoint
branch
from
January 18, 2025 01:08
2f2ee47
to
253022f
Compare
jkeiser
force-pushed
the
jkeiser/apply-changeset-endpoint
branch
from
January 18, 2025 01:46
253022f
to
b978e40
Compare
jkeiser
changed the title
feat(sdf): Add force_apply/request_approval automation API endpoints
feat(sdf): Add apply/merge_status automation API endpoints
Jan 18, 2025
@jkeiser Component type would be super useful in this response
|
@johnrwatson will do! I want to get this merged soon to unblock, but I'll post a followup with a little more meat on the responses! |
britmyerss
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
I've tested all three of these endpoints through curl. There are no automated tests in this commit (as with other automation API endpoints), but tests of the github action itself (which are more end to end) will include these. There will be a couple more turns of the crank on these APIs over the next week.
I have verified existing functionality is generally working through the webui as well (creating components, running management functions, and applying changesets). Beyond that, this is entirely new code, limited to the new endpoints under a feature flag, so there should be no risk to the main product.