chore: nix flake update #5474
Merged
chore: nix flake update #5474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
nickgerace
previously approved these changes
Feb 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@sprutton1 @fnichol these errors look a bit gnarly. I'm guessing updating the flake pushed some stuff over the edge? |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
fnichol
force-pushed
the
adamhjk/nix-flake-update
branch
from
d984c1e to
5fabcc6
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
It's looking like we'll have to expand our Cyclone rootfs size again, I'll take a look |
|
Nevermind, more like a dangling symlink when building |
|
New commit clears this error, confirmed locally on an x86_64-linux system by running: |
sprutton1
approved these changes
Feb 14, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
fnichol
force-pushed
the
adamhjk/nix-flake-update
branch
from
86218be to
ef76ee2
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Upgrade the versions of whats in our nix flake, in particular to catch an updated version of cfn-lint
This fixes an issue where a Nix build phase now detects broken symlinks. This was happening by design as we were creating a symlink for both x86_64-linux and aarch64-linux systems no matter which system package was being built. The error was: ``` lang-js> ERROR: noBrokenSymlinks: the symlink /nix/store/yc5yb3cdvjyqzykwf4nz1w1aj9vxxxs9-lang-js/lib/ld-linux-x86-64.so.2 points to a missing target /nix/store /4j0ghmjl1hia5h4fx9szjz0zzlr4ck9b-glibc-2.40-66/lib/ld-linux-x86-64.so.2 lang-js> ERROR: noBrokenSymlinks: found 1 dangling symlinks and 0 reflexive symlinks error: builder for '/nix/store/qkdscpxj0ig5njnh39sbcwgyipiaxx1b-lang-js.drv' failed with exit code 1 ``` The fix provided here computes the appropriate file name for the given system and uses that when creating the symlink. Signed-off-by: Fletcher Nichol <[email protected]>
fnichol
force-pushed
the
adamhjk/nix-flake-update
branch
from
ef76ee2 to
0dba463
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the versions of whats in our nix flake, in particular to catch an updated version of cfn-lint