Revert "Move special case funcs to intrinsics" #5478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-sdf
nickgerace
previously approved these changes
Feb 14, 2025
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
stack72
force-pushed
the
revert-5451-nick/eng-2931
branch
from
a5a7185 to
2faf760
Compare
fnichol
approved these changes
Feb 14, 2025
nickgerace
approved these changes
Feb 14, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
nickgerace
added a commit
that referenced
this pull request
Feb 14, 2025
This commit fixes two flake-y tests by waiting for actions to run related to "Starfield". Interestingly, this should have only started happening after #5451, which was reverted by #5478 and is intended to come back on "main" after #5485 is approved and merged. That being said, this can happen for a number of reasons, but the key takeaway is that we should be waiting for actions to run whenver possible in our tests. Signed-off-by: Nick Gerace <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5451