feat(si-fs): support deno #5491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
fnichol
force-pushed
the
si-fs/deno-types
branch
from
d3a7d6f to
521a01a
Compare
|
I rebased this work to make sure that it would benefit from updated Nix software |
|
I'll review today, sorry I ran out of time Friday |
Supports deno by configuring a workspace root deno.json and a .vscode/settings.json with "deno: enable". In order to support deno we prefetch every function so we can fill out the deno.json workspaces list. If new functions come in, or are created, *you will have to reload your deno workspace to get them parsed by the deno language server*. `node_modules` for deno are not yet supported. They can be! But a passthrough will have to be implemented so that the node module tree can be written to disk in another folder, and mirrored in the si-filesystem system.
fnichol
force-pushed
the
si-fs/deno-types
branch
from
521a01a to
e58cc45
Compare
fnichol
approved these changes
Feb 20, 2025
|
Note that this PR will produce an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports deno by configuring a workspace root deno.json and a .vscode/settings.json with "deno: enable". In order to support deno we prefetch every function so we can fill out the deno.json workspaces list.
If new functions come in, or are created, you will have to reload your deno workspace to get them parsed by the deno language server.
node_modulesfor deno are not yet supported. They can be! But a passthrough will have to be implemented so that the node module tree can be written to disk in another folder, and mirrored in the si-filesystem system.