Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(si-pkg): allow generation of a spec without any unique info #5547

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

sprutton1
Copy link
Contributor

  • makes it so a PkgSpec can anonymize itself, i.e. set all unique info (dates, ids, etc.) to an empty or known value
  • adds a command to hoist to let it transform specs into anonymous specs

these anonymous specs will be used for

  • generating hashes that don't include ids that can be stored in the module index to make comparison of specs more accurate
  • generating diffs that ignore redundant information
buck2 run //bin/hoist:hoist -- anonymize-specs -t ./bin/clover/si-specs -o ./test

@sprutton1 sprutton1 requested a review from jkeiser February 24, 2025 22:18
Copy link

github-actions bot commented Feb 24, 2025

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@sprutton1 sprutton1 changed the title Si pkg/anonymize feat(si-pkg): allow generation of a spec without any unique info Feb 24, 2025
Copy link
Contributor

@vbustamante vbustamante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a question there, maybe a typo?

@sprutton1 sprutton1 enabled auto-merge February 25, 2025 15:16
@sprutton1 sprutton1 added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit b4028e6 Feb 25, 2025
9 checks passed
@sprutton1 sprutton1 deleted the si-pkg/anonymize branch February 25, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants