Add NATS event callback metrics #5554
Merged
+32
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds NATS event callback metrics and other logging during events callback. This allows us to detect issues upon reconnection, sending messages after "publishing" them (i.e. sent in an internal channel to be sent to the server later), etc. As part of these changes, we also fix some "si.error.message" locations. Co-authored-by: Fletcher Nichol <[email protected]> Signed-off-by: Nick Gerace <[email protected]>
github-actions
bot
added
A-si-settings
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
sprutton1
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds NATS event callback metrics and other logging during events callback. This allows us to detect issues upon reconnection, sending messages after "publishing" them (i.e. sent in an internal channel to be sent to the server later), etc.
As part of these changes, we also fix some "si.error.message" locations.