This repository has been archived by the owner on Sep 16, 2022. It is now read-only.
#173 Replace alert with SnackError for quiz. #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalabro
reviewed
Jun 4, 2022
| show={this.state.alertOpen} | ||
| message={Drupal.t('Quiz submission failed. Please try again.', {}, { context: 'ANU LMS' })} | ||
| onClose={() => this.setState({ alertOpen: false })} | ||
| severity='warning' |
There was a problem hiding this comment.
@gease why did you decide to use warning severity here?
There was a problem hiding this comment.
why did you decide to use warning severity here?
Arbitrary choice. Change to whatever you like.
As for QuizOptionsHandler, this component seems to never be rendered. At least i failed to find where it is.
@kalabro ^^
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is also alert() on error in js/src/components/QuizOptionsHandler.js, but under condition !isQuiz (
anu_lms/js/src/components/QuizOptionsHandler.js
Line 117 in 57c6c61
anu_lms/js/src/components/QuizOptionsHandler.js
Line 58 in 57c6c61