Use %H for output generated with iostat -t #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raharper Thank you for sending a patch. I updated the master branch so that github actions can run. Could you rebase? |
raharper
force-pushed
the
fix/iostat-time-format-24h
branch
from
8ddf67c to
764907c
Compare
|
@raharper Thank you for rebasing. I confirmed a test failed. Could you confirm and fix the wrong tests? |
LANG=en_US.UTF-8 iostat -t generates timestamps which use 24-hour time This does not match the IOSTAT_DATE_FORMAT_JA, which uses %I, 12-hour value and would require a %p for AM/PM; in any case, the JA format is not generated by iostat. Fix the examples and switch %I -> %H Fixes: t2y#5 Signed-off-by: Ryan Harper <[email protected]>
raharper
force-pushed
the
fix/iostat-time-format-24h
branch
from
764907c to
4884547
Compare
I've pushed a fix. I was able to run the testsuite with: |
|
Thank you for fixing the problem. I confirmed a CI job succeeded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LANG=en_US.UTF-8 iostat -t generates timestamps which use 24-hour time This does not match the IOSTAT_DATE_FORMAT_JA, which uses %I, 12-hour value and would require a %p for AM/PM; in any case, the JA format is not generated by iostat. Fix the examples and switch %I -> %H
Fixes: #5