feat(interpreter): method calls #1652
Conversation
| if (selfT.kind !== "ref") { | ||
| throwNonFatalErrorConstEval( | ||
| `currently, method calls only support reference type methods`, | ||
| ast.loc, | ||
| ); | ||
| } |
There was a problem hiding this comment.
why not support any sensible type and let the typechecker reject some programs?
There was a problem hiding this comment.
Typechecking is actually not executed before interpretation in some parts of the compiler, like constant initialization. This causes problems. I just opened an issue #1655.
| break; | ||
| case "native_function_decl": | ||
| throwNonFatalErrorConstEval( | ||
| "native function calls are currently not supported", |
There was a problem hiding this comment.
most likely will never be supported
There was a problem hiding this comment.
I'll change the message to "native functions are not supported".
There was a problem hiding this comment.
I'll change the message to "native functions are not supported".
I'd just remove the currently: "native function calls are not supported".
Otherwise, it may seem as if we don't support them at all (outside the interpreter) :)
|
Requires PR #1678 to be merged into main for new tests to succeed. |
anton-trunov
changed the title
|
Closing this for now, feel free to fix the merge conflicts and finish it after we release Tact 1.6 |
Issue
Closes #1646.
Code is ready, but I am adding tests.
Checklist
docs/and made the build locally