Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(codegen): inline contract router #1968

Merged
merged 6 commits into from
Feb 24, 2025
Merged

refactor(codegen): inline contract router #1968

merged 6 commits into from
Feb 24, 2025

Conversation

anton-trunov
Copy link
Member

@anton-trunov anton-trunov commented Feb 23, 2025

This requires inlining receivers as well.
Reduces gas usage of the Jetton benchmarks.
But increases gas usage for Escrow (I think we can live with it for now, until #1866 is resolved).

Issue

Closes #1587.

Gas Benchmarks

image image

Checklist

  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings (but I really wanted to do it)

This requires inlining receivers as well.
Reduces gas usage of the Jetton benchmarks.
But increases gas usage for Escrow.
@anton-trunov anton-trunov added this to the v1.6.0 milestone Feb 23, 2025
@anton-trunov anton-trunov requested a review from a team as a code owner February 23, 2025 17:54
Copy link
Contributor

@Kaladin13 Kaladin13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General logic is solid, good thing we have #1949 since we will catch all possible router bugs there, if there are any, after this massive codegen changes

Few notes in review

Kaladin13
Kaladin13 previously approved these changes Feb 24, 2025
Copy link
Contributor

@Kaladin13 Kaladin13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@anton-trunov anton-trunov merged commit 3de07e3 into main Feb 24, 2025
24 checks passed
@anton-trunov anton-trunov deleted the inline-router branch February 24, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline contract routers at codegen stage
2 participants